Add explicit cast to base58 and bech32 string constants in order to silence GCC warning #14486

pull DesWurstes wants to merge 1 commits into bitcoin:master from DesWurstes:patch-4 changing 2 files +2 −2

DesWurstes commented at 1:48 PM on October 15, 2018: contributor

May I also constexprize them in this Pull Request?
Add explicit cast to base58 and bech32 string constants fffffffd7f
fanquake added the label Refactoring on Oct 15, 2018
ken2812221 commented at 4:45 AM on October 16, 2018: contributor

Could you elaborate more details? I don't understand what your purpose is.
DesWurstes commented at 1:37 PM on October 16, 2018: contributor

~~In standard C++, const char*a="abc"; is illegal. (const char *) is required, and const_cast<char*> is the C++ way to do that.~~
practicalswift commented at 2:34 PM on October 16, 2018: contributor

@DesWurstes I'm not sure I follow. Can you post the GCC warning you're trying to get rid of?
sipa commented at 2:50 PM on October 16, 2018: member

Why is that illegal?
DesWurstes commented at 3:14 PM on October 16, 2018: contributor

Erroneous observation due to blind constexpr replacements. It was char * k="d"; that was illegal.forgive me.
DesWurstes closed this on Oct 16, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels