doc: Remove explicit storage requirement from README.md #14511

pull merland wants to merge 1 commits into bitcoin:master from merland:patch-1 changing 1 files +1 −1
  1. merland commented at 12:21 pm on October 18, 2018: contributor
    Similarly discussed and fixed in the following bitcoin.org issue: https://github.com/bitcoin-dot-org/bitcoin.org/pull/2716
  2. fanquake added the label Docs on Oct 18, 2018
  3. laanwj commented at 2:35 pm on October 18, 2018: member

    didn’t even know there was another reference to the size here; there’s this one in the release process

    0* Update [`BLOCK_CHAIN_SIZE`](/src/qt/intro.cpp) to the current size plus some overhead
    

    maybe better to remove this one completely

  4. in doc/README.md:6 in 3a4757c2bb outdated
    2@@ -3,7 +3,7 @@ Bitcoin Core
    3 
    4 Setup
    5 ---------------------
    6-Bitcoin Core is the original Bitcoin client and it builds the backbone of the network. It downloads and, by default, stores the entire history of Bitcoin transactions (which is currently more than 100 GBs); depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to a day or more.
    7+Bitcoin Core is the original Bitcoin client and it builds the backbone of the network. It downloads and, by default, stores the entire history of Bitcoin transactions, which requires several hundred gigabytes of disk space. Depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to a day or more.
    


    promag commented at 4:53 pm on October 18, 2018:
    Could say that currently grows around 50GB/year?

    laanwj commented at 5:31 pm on October 18, 2018:
    I don’t think that’s very useful here (as there is no reference, from where it grows, so it doesn’t tell the user anything more about how much they need)

    merland commented at 5:44 pm on October 18, 2018:
    This doc is not a guide for running a node, but a more general text. As such, it does not need to be specific about the storage reqs, in my opinion. This passage would benefit from a general enough phrasing that won’t need to be updated for a long time. Even the text “several hundred gigabytes” is not future proof, but that may be an ok tradeoff. If we find a good and independent reference source for the size further on, we can add a link to it then.

    kristapsk commented at 7:59 pm on October 18, 2018:
    0Bitcoin Core is the original Bitcoin client and it builds the backbone of the network. It downloads and, by default, stores the entire history of Bitcoin transactions, which requires few hundred gigabytes of disk space. Depending on the speed of your computer and network connection, the synchronization process can take anywhere from a few hours to a day or more.
    

    It’s currently around 200 GB, so I think “few” would be a better wording than “several” for now.

  5. laanwj commented at 5:31 pm on October 18, 2018: member
    looks good to me now!
  6. jonasschnelli commented at 5:49 pm on October 18, 2018: contributor
    ACK 3a4757c2bba8cd59c08dc8b717e527115018c600
  7. promag commented at 5:52 pm on October 18, 2018: member
    ACK.
  8. donaloconnor commented at 10:04 pm on October 18, 2018: contributor
    ACK
  9. kristapsk changes_requested
  10. fanquake renamed this:
    Increase storage requirement from 100GB to 200GB
    doc: Remove explicit storage requirement from README.md
    on Oct 19, 2018
  11. fanquake commented at 2:39 am on October 19, 2018: member
    ACK please squash your commits
  12. merland force-pushed on Oct 22, 2018
  13. merland force-pushed on Oct 22, 2018
  14. Removed explicit mention of storage requirement (squashed)
    Similarly discussed and fixed in the following bitcoin.org issue: https://github.com/bitcoin-dot-org/bitcoin.org/pull/2716
    
    Removed mention of storage requirement
    
    Agreeing with @laanwj that this mention of the storage requirement could be removed, I did so and changed the wording accordingly.
    Would be nice to be able to add a link to a canonical source that is always updated, for those who want a number.
    
    Update doc/README.md
    
    Co-Authored-By: merland <martin@megabit.se>
    
    Update README.md
    
    added a missing 'a'
    5918204304
  15. merland force-pushed on Oct 22, 2018
  16. merland commented at 1:07 pm on October 22, 2018: contributor
    Thanks for your comments. Squashed 4 commits.
  17. fanquake commented at 10:54 pm on October 22, 2018: member
    utACK 5918204
  18. sipa commented at 1:42 am on October 23, 2018: member
    ACK
  19. sipa merged this on Oct 23, 2018
  20. sipa closed this on Oct 23, 2018

  21. sipa referenced this in commit b3f377daaa on Oct 23, 2018
  22. merland deleted the branch on Apr 15, 2019
  23. Munkybooty referenced this in commit ab7bb8320a on Jul 21, 2021
  24. Munkybooty referenced this in commit e48402d33a on Jul 22, 2021
  25. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me