rpc: Always throw in getblockstats if -txindex is required #14518

1. 
   promag commented at 2:31 PM on October 19, 2018: member

   Previously blocks with only the coinbase transaction didn't cause the RPC error even if the requested stats required -txindex and it wasn't enabled.

   Fixes #14499.

2. rpc: Always throw in getblockstats if -txindex is required

   Previously blocks with only the coinbase transaction didn't cause
   the RPC error even if the requested stats required -txindex and
   it wasn't enabled.

   3be209d103
3. fanquake added the label RPC/REST/ZMQ on Oct 19, 2018
4. 
   sipa commented at 2:01 AM on October 20, 2018: member

   utACK 3be209d103297aaf2fe4711e237a65046488ea19

5. 
   MarcoFalke commented at 6:39 AM on October 20, 2018: member

   utACK 3be209d103297aaf2fe4711e237a65046488ea19

6. 
   promag commented at 3:51 PM on October 24, 2018: member

   @jtimon @gmaxwell care to review?

7. 
   conscott commented at 6:38 AM on October 25, 2018: contributor

   Tested ACK 3be209d103297aaf2fe4711e237a65046488ea1

   I had also been confused by this behavior before, so this seems right.

8. 
   laanwj commented at 11:22 AM on October 26, 2018: member

   utACK 3be209d103297aaf2fe4711e237a65046488ea19

9. laanwj added the label Backport on Oct 26, 2018
10. laanwj added this to the milestone 0.17.1 on Oct 26, 2018
11. laanwj merged this on Oct 26, 2018
12. laanwj closed this on Oct 26, 2018

    ---

13. laanwj referenced this in commit 9d4541508b on Oct 26, 2018
14. promag deleted the branch on Oct 26, 2018
15. deadalnix referenced this in commit b569951c2c on May 29, 2020
16. Munkybooty referenced this in commit 25b8a4ea07 on Jul 21, 2021
17. Munkybooty referenced this in commit 459cfb205b on Jul 21, 2021
18. Munkybooty referenced this in commit 41ce116f3b on Jul 22, 2021
19. Munkybooty referenced this in commit 8511568e10 on Jul 22, 2021
20. Munkybooty referenced this in commit 07c0eec88c on Jul 23, 2021
21. DrahtBot locked this on Sep 8, 2021

Milestone
0.17.1