qt, docs: Fix bitcoin-qt -version output formatting #14521

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20181019-qt-cli-license changing 2 files +5 −4
  1. hebasto commented at 5:23 pm on October 19, 2018: member

    This PR makes command line output of bitcoin-qt -version formatted in the same way as bitcoind -version output.

    Before: screenshot from 2018-10-19 20-16-42

    After: screenshot from 2018-10-19 20-22-09

  2. molxyz commented at 5:36 pm on October 19, 2018: none
    @hebasto This screen is for “About Bitcoin Core”, so I would like to have it kept as clean and professional looking as possible. There’s a screen for “About Qt” under Help that you might want to look at? Although I still don’t see the purpose for this. Please do not keep trying to change trivial, unnecessary things for Bitcoin Core, it’s just a waste of devs time for more important improvements.
  3. MarcoFalke added the label GUI on Oct 20, 2018
  4. merland commented at 1:50 pm on October 23, 2018: contributor

    @molxyz Regarding your comment about changing “trivial” things: Isn’t that a very good way for newcomers to get used to the contribution process and learn the way around the docs and the code? I certainly think so. And in the process, Bitcoin Core gets many small improvements in areas where more experienced devs rarely work. It’s a win-win!

    If “trivial” PRs take too much time for devs, we have a delegation problem. Reviewing “trivial” PRs could and should be delegated appropriately. Please don’t scare away newcomers that want to (learn how to) contribute. I am one them.

  5. DrahtBot commented at 10:07 pm on October 23, 2018: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    No conflicts as of last run.

  6. fanquake commented at 10:01 am on October 28, 2018: member

    An uninteresting trip into all? the different place/ways we display version information (efaf2d8):

     0src/qt/bitcoin-qt -version
 1Bitcoin Core version v0.17.99.0-efaf2d85e (64-bit)
 2Copyright (C) 2009-2018 The Bitcoin Core developers
 3
 4Please contribute if you find Bitcoin Core useful. Visit <https://bitcoincore.org> for further information about the software.
 5The source code is available from <https://github.com/bitcoin/bitcoin>.
 6
 7This is experimental software.
 8Distributed under the MIT software license, see the accompanying file COPYING or <https://opensource.org/licenses/MIT>
 9
10This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit <https://www.openssl.org> and cryptographic software written by Eric Young and UPnP software written by Thomas Bernard.

     0src/bitcoind -version
 1Bitcoin Core Daemon version v0.17.99.0-efaf2d85e
 2Copyright (C) 2009-2018 The Bitcoin Core developers
 3
 4Please contribute if you find Bitcoin Core useful. Visit
 5<https://bitcoincore.org> for further information about the software.
 6The source code is available from <https://github.com/bitcoin/bitcoin>.
 7
 8This is experimental software.
 9Distributed under the MIT software license, see the accompanying file COPYING
10or <https://opensource.org/licenses/MIT>
11
12This product includes software developed by the OpenSSL Project for use in the
13OpenSSL Toolkit <https://www.openssl.org> and cryptographic software written by
14Eric Young and UPnP software written by Thomas Bernard.

    0src/bitcoin-cli -version
1Bitcoin Core RPC client version v0.17.99.0-efaf2d85e

    About Bitcoin Core: about bitcoin core

    Command Line Options: command line options

    Debug Console: debug console

    After (This PR 368bd04):

     0src/qt/bitcoin-qt -version
 1Bitcoin Core version v0.17.99.0-c61ee8181 (64-bit)
 2Copyright (C) 2009-2018 The Bitcoin Core developers
 3
 4Please contribute if you find Bitcoin Core useful. Visit
 5<https://bitcoincore.org> for further information about the software.
 6The source code is available from <https://github.com/bitcoin/bitcoin>.
 7
 8This is experimental software.
 9Distributed under the MIT software license, see the accompanying file COPYING
10or <https://opensource.org/licenses/MIT>
11
12This product includes software developed by the OpenSSL Project for use in the
13OpenSSL Toolkit <https://www.openssl.org> and cryptographic software written by
14Eric Young and UPnP software written by Thomas Bernard.

    It seems that whatever FormatParagraph is meant to be doing doesn’t have much of an affect in the About Core dialog, as the output appears the same with or without this commit.

  7. hebasto commented at 10:45 am on October 28, 2018: member

    @fanquake Thank you for your review.

    This PR is intended only for the -version command-line option of bitcoin-qt. “About Bitcoin Core” dialog is a resizable window, therefore it does not need FormatParagraph.

  8. DrahtBot added the label Needs rebase on Nov 5, 2018
  9. Fix `bitcoin-qt -version` output formatting 60ae463a68
  10. hebasto force-pushed on Nov 5, 2018
  11. hebasto commented at 11:39 am on November 5, 2018: member
    Rebased.
  12. DrahtBot removed the label Needs rebase on Nov 5, 2018
  13. jonasschnelli approved
  14. jonasschnelli commented at 2:22 am on November 7, 2018: contributor
    utACK 60ae463a68206b08faaadfbb023d7ede78fff784
  15. laanwj merged this on Nov 23, 2018
  16. laanwj closed this on Nov 23, 2018
  17. laanwj referenced this in commit 59f05d1161 on Nov 23, 2018
  18. hebasto deleted the branch on Nov 23, 2018
  19. jasonbcox referenced this in commit e0818f956a on Nov 10, 2020
  20. linuxsh2 referenced this in commit 1302c30cb4 on Jul 27, 2021
  21. linuxsh2 referenced this in commit 5ad18a98ce on Jul 27, 2021
  22. linuxsh2 referenced this in commit 70826d54b2 on Jul 27, 2021
  23. linuxsh2 referenced this in commit df0701957d on Jul 27, 2021
  24. linuxsh2 referenced this in commit ec3de03959 on Jul 27, 2021
  25. linuxsh2 referenced this in commit 23d880d793 on Jul 28, 2021
  26. linuxsh2 referenced this in commit 2161a3106f on Jul 28, 2021
  27. linuxsh2 referenced this in commit 2efd30dc30 on Jul 28, 2021
  28. linuxsh2 referenced this in commit f48f20a5ce on Jul 28, 2021
  29. Munkybooty referenced this in commit 0c12f95eae on Jul 30, 2021
  30. linuxsh2 referenced this in commit 40d649da54 on Jul 30, 2021
  31. Munkybooty referenced this in commit f74e4f5b47 on Aug 3, 2021
  32. MarcoFalke locked this on Sep 8, 2021


hebasto molxyz merland DrahtBot fanquake jonasschnelli

Labels
GUI

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me