bitcoin-cli loadwallet "wallet.dat" command causes bitcoind crash
log info:
0bitcoind: wallet/db.cpp:236: BerkeleyEnvironment::VerifyResult BerkeleyEnvironment::Verify(const string&, BerkeleyEnvironment::recoverFunc_type, std::__cxx11::string&): Assertion `mapFileUseCount.count(strFile) == 0' failed.
1Aborted (core dumped)
Bitcoin Core Daemon version v0.17.0.0-ge1ed37edaedc85b8c3468bd9a726046344036243
Fix from ken2812221 looks right, but I would want to tweak it a bit so wallet.dat is handled at the database layer. I’ll post a suggestion in #14552.
This issue was really confusing to debug. We have two different checks to prevent opening the same wallet multiple times, and this is slipping between the two checks. The more general check is in CheckUniqueFileid:
but because it runs lazily, it is skipped if the btree path is already open:
We have a different check in CWallet::Verify which checks for duplicate paths:
But it is somewhat broken and #14552 fixes it. The actual crash (at least the crash triggered by the test in #14552) happens in an assert here:
this is becoming real problem for me as well, the daemon crashes without any trace, here is what debug.log file has to say about this:
2018-10-25T11:05:28Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010) 2018-10-25T11:05:28Z Using wallet wallet.dat 2018-10-25T11:05:28Z init message: Loading wallet… 2018-10-25T11:05:28Z [62055ff271e502760352b420d4f9b39e015ee2c4] nFileVersion = 170000 2018-10-25T11:05:28Z [62055ff271e502760352b420d4f9b39e015ee2c4] Keys: 0 plaintext, 4035 encrypted, 4035 w/ metadata, 4035 total. Unknown wallet records: 1 2018-10-25T11:05:28Z Using BerkeleyDB version Berkeley DB 4.8.30: (April 9, 2010) 2018-10-25T11:05:28Z Using wallet wallet.dat
Even though it says Using BerkelyDB… etc.. in final 2 lines but in fact daemon is already crashed
p.s. “62055f….” is name of a wallet
@furqansiddiqui are you sure this is the same issue? The crash reported here happens when loading the same wallet file twice. There is a flaw in the check for already-loaded wallets that sometimes allows an already opened wallet to be partially reopened, resulting in a crash instead of a clean error message.
If the crash you’re seeing is not a result of trying to load a wallet that is already loaded, it would be helpful if you could create a new github issue and describe your configuration and command lines so we can attempt to debug it.
Actually in my implementation a wallet is dynamically loaded at start of HTTP request and released/unloaded as it ends, this issue arises when a user repeatedly refreshes (actually just hitting F5 few times within a second) therefore I am sure its related to loading a wallet that is already loaded or in process of being loaded at node. I will of course do some fix from my end but I firmly believe this needs to be resolved and at very least need to have proper crash log so I can perhaps able to modify flow on my end
On Thu, Oct 25, 2018 at 4:40 PM Russell Yanofsky notifications@github.com wrote:
@furqansiddiqui https://github.com/furqansiddiqui are you sure this is the same issue? The crash reported here happens when loading the same wallet file twice. There is a flaw in the check for already-loaded wallets that sometimes allows an already opened wallet to be partially reopened, resulting in a crash instead of a clean error message.
If the crash you’re seeing is not a result of trying to load a wallet that is already loaded, it would be helpful if you could create a new github issue and describe your configuration and command lines so we can attempt to debug it.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/14538#issuecomment-433017551, or mute the thread https://github.com/notifications/unsubscribe-auth/AK9ABfjBL094WMDPdjrsJFKN4S8v6iCdks5uoaMTgaJpZM4XynCo .
– Regards, Mfurqan Sid.
Cell: +923212275432
unloadwallet RPC returns:
https://github.com/bitcoin/bitcoin/blob/613fc95ee4ead5962e960137e694aec5888e2680/src/wallet/rpcwallet.cpp#L2532-L2541
Okay but it is guaranteed that wallet is unloaded when we see releasing wallet message in log?
I am sure a solution to this issue will also resolve mine
On Thu, Oct 25, 2018, 4:52 PM João Barbosa notifications@github.com wrote:
@furqansiddiqui https://github.com/furqansiddiqui it is not guaranteed that the wallet is unloaded when the unloadwallet RPC returns.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/issues/14538#issuecomment-433020643, or mute the thread https://github.com/notifications/unsubscribe-auth/AK9ABW-8dKW3h23w32wvJn5WSjlbDRfpks5uoaXigaJpZM4XynCo .
Okay but it is guaranteed that wallet is unloaded when we see releasing wallet message in log?
Yes. I’m not sure what your problem is but as @ryanofsky said, better open a new issue since the original issue here is fixed by #14552.
@furqansiddiqui, if you are able to build master, I think it is likely #14320 fixes your problem, and if it doesn’t I would definitely encourage you to report a new issue with information about your configuration.
From what you are describing, the issue reported here is not directly related and #14552 will not fix it. The issue reported here is about a crash that happens when attempting to load the same wallet with different path strings, and a flaw in bitcoind where it assumes the paths refer to different wallets and tries to load both.
It sounds like if someone is hitting F5 repeatedly on your site it will attempt to load the same wallet with the same path string. If this is causing crashes and #14320 doesn’t fix it, this is something we will need to fix separately, so I’d encourage you to file an issue and maybe test #14320.
I am getting following error when running make command after checking out master and pulling latest commits
make[3]: Leaving directory ‘/root/bitcoin’ CXX wallet/libbitcoin_wallet_a-walletutil.o wallet/walletutil.cpp: In function ‘std::vectorboost::filesystem::path ListWalletDir()’: wallet/walletutil.cpp:60:32: error: ‘relative’ is not a member of ‘fs’ paths.emplace_back(fs::relative(it->path(), wallet_dir)); ^ wallet/walletutil.cpp:71:36: error: ‘relative’ is not a member of ‘fs’ paths.emplace_back(fs::relative(it->path(), wallet_dir)); ^ Makefile:6911: recipe for target ‘wallet/libbitcoin_wallet_a-walletutil.o’ failed make[2]: *** [wallet/libbitcoin_wallet_a-walletutil.o] Error 1 make[2]: Leaving directory ‘/root/bitcoin/src’ Makefile:10249: recipe for target ‘all-recursive’ failed make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory ‘/root/bitcoin/src’ Makefile:774: recipe for target ‘all
@furqansiddiqui, if you are able to build master, I think it is likely #14320 fixes your problem, and if it doesn’t I would definitely encourage you to report a new issue with information about your configuration.
From what you are describing, the issue reported here is not directly related and #14552 will not fix it. The issue reported here is about a crash that happens when attempting to load the same wallet with different path strings, and a flaw in bitcoind where it assumes the paths refer to different wallets and tries to load both.
It sounds like if someone is hitting F5 repeatedly on your site it will attempt to load the same wallet with the same path string. If this is causing crashes and #14320 doesn’t fix it, this is something we will need to fix separately, so I’d encourage you to file an issue and maybe test #14320.
@furqansiddiqui either use most recent boost or change to #14561 branch instead of master.
changed to #14561 branch, tried but no it doesn’t fix my issue, I will open new issue then