Fix #13299.
Since the default nSequence is 0xFFFFFFFE and locktime is enabled, the checking wtx.is_final is meaningless until the syncing has completed (ref: #1026).
This PR makes the wallet mark a transaction “Unconfirmed” instead of misleading “Open for NNN more blocks” when syncing after a period of being offline.
Before this PR (with the issue):
With this PR (the issue has been resolved):
179- if (wtx.lock_time < LOCKTIME_THRESHOLD)
180- {
181+ QDateTime currentDate = QDateTime::currentDateTime();
182+ qint64 secs = blockDate.secsTo(currentDate);
183+
184+ if ((secs < 90 * 60) && !wtx.is_final) {
90 * 60 here is meant to match the if(secs < 90*60) in src/qt/bitcoingui.cpp, right? If so, I suggest adding a common constant to make sure these values stay in sync over time :-)
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
191@@ -193,8 +192,8 @@ class TransactionTablePriv
192 // simply re-use the cached status.
193 interfaces::WalletTxStatus wtx;
194 int numBlocks;
195- if (wallet.tryGetTxStatus(rec->hash, wtx, numBlocks) && rec->statusUpdateNeeded(numBlocks)) {
196- rec->updateStatus(wtx, numBlocks);
197+ if (wallet_model->wallet().tryGetTxStatus(rec->hash, wtx, numBlocks) && rec->statusUpdateNeeded(numBlocks)) {
198+ rec->updateStatus(wtx, numBlocks, QDateTime::fromTime_t(wallet_model->node().getLastBlockTime()));
QDateTime::fromTime_t(wallet_model->node().getLastBlockTime()) for each record mostly because of excessive cs_main locks.
7@@ -8,6 +8,7 @@
8 #include <amount.h>
9 #include <uint256.h>
10
11+#include <QDateTime>
23@@ -23,6 +24,8 @@ struct WalletTxStatus;
24 class TransactionStatus
25 {
26 public:
27+ static constexpr int TIME_AGO_OF_LAST_BLOCK_IN_SECONDS = 90 * 60;
15@@ -16,6 +16,7 @@
16 #include <qt/optionsmodel.h>
17 #include <qt/platformstyle.h>
18 #include <qt/rpcconsole.h>
19+#include <qt/transactionrecord.h>
Since the default `nSequence` is `0xFFFFFFFE` and locktime is enabled,
the checking `wtx.is_final` is meaningless until the syncing has
completed.
32+
33+/**
34+ * Maximum gap between node time and block time used
35+ * for the "Catching up..." mode in GUI.
36+ *
37+ * Ref: https://github.com/bitcoin/bitcoin/pull/1026
