wallet: Avoid calling uiInterface.LoadWallet(…) with cs_wallet held #14560

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:uiInterface.LoadWallet-without-cs_wallet changing 1 files +3 −1
  1. practicalswift commented at 10:13 am on October 24, 2018: contributor

    Follow-up to #11634.

    Context: #11634 (review)

  2. wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held aa367b6364
  3. MarcoFalke commented at 10:39 am on October 24, 2018: member
    Can you explain why this is needed?
  4. fanquake added the label Wallet on Oct 24, 2018
  5. promag commented at 10:47 am on October 24, 2018: member
    @MarcoFalke before #11634 the lock wasn’t held when calling uiInterface.LoadWallet(walletInstance). My suggestion was to revert that behaviour change.
  6. MarcoFalke commented at 11:16 am on October 24, 2018: member
    Yeah, I don’t see the change in behaviour. Is there any?
  7. promag commented at 11:26 am on October 24, 2018: member
    Ok, updated my comment.
  8. MarcoFalke added the label Refactoring on Oct 24, 2018
  9. MarcoFalke commented at 11:40 am on October 24, 2018: member
    Ah ok. Slightly tend to NACK due to our refactoring guidelines.
  10. practicalswift commented at 12:03 pm on October 24, 2018: contributor
    @MarcoFalke Makes sense! Closing :-)
  11. practicalswift closed this on Oct 24, 2018

  12. promag commented at 12:11 pm on October 24, 2018: member
    I don’t get it why this is refactoring, this should just revert something that was changed for no good reason. Anyway it was just a comment.
  13. practicalswift deleted the branch on Apr 10, 2021
  14. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-22 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me