Follow-up to #11634.
Context: #11634 (review)
wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held #14560
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:uiInterface.LoadWallet-without-cs_wallet changing 1 files +3 −1-
practicalswift commented at 10:13 AM on October 24, 2018: contributor
-
wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held aa367b6364
-
MarcoFalke commented at 10:39 AM on October 24, 2018: member
Can you explain why this is needed?
- fanquake added the label Wallet on Oct 24, 2018
-
promag commented at 10:47 AM on October 24, 2018: member
@MarcoFalke before #11634 the lock wasn't held when calling
uiInterface.LoadWallet(walletInstance). My suggestion was to revert thatbehaviourchange. -
MarcoFalke commented at 11:16 AM on October 24, 2018: member
Yeah, I don't see the change in behaviour. Is there any?
-
promag commented at 11:26 AM on October 24, 2018: member
Ok, updated my comment.
- MarcoFalke added the label Refactoring on Oct 24, 2018
-
MarcoFalke commented at 11:40 AM on October 24, 2018: member
Ah ok. Slightly tend to NACK due to our refactoring guidelines.
-
practicalswift commented at 12:03 PM on October 24, 2018: contributor
@MarcoFalke Makes sense! Closing :-)
- practicalswift closed this on Oct 24, 2018
-
promag commented at 12:11 PM on October 24, 2018: member
I don't get it why this is refactoring, this should just revert something that was changed for no good reason. Anyway it was just a comment.
- practicalswift deleted the branch on Apr 10, 2021
- DrahtBot locked this on Aug 16, 2022
