build: Fix Qt link order for Windows build #14568

1. 
   ken2812221 commented at 12:15 pm on October 25, 2018: contributor

   See #14451 (comment)
2. build: Fix Qt link order for Windows build fbaccbf00c
3. fanquake added the label Build system on Oct 25, 2018
4. 
   laanwj commented at 12:57 pm on October 25, 2018: member

   great!

   can you please explain how swapping these around fixes the build? something with qt depending on libssl?

5. MarcoFalke added the label Needs gitian build on Oct 25, 2018
6. 
   MarcoFalke commented at 12:59 pm on October 25, 2018: member

   Concept ACK. Also interesting that travis didn’t fail on this. travis apparently doesn’t build the gui.
7. ryanofsky approved
8. 
   ryanofsky commented at 2:02 pm on October 25, 2018: member

   utACK fbaccbf00cbb377f266d03f3c5a6b07a9a96a07a. Seems clearly correct, SSL_LIBS should be listed after the libraries that depend on it.
9. 
   ken2812221 commented at 3:08 am on October 26, 2018: contributor

   can you please explain how swapping these around fixes the build? something with qt depending on libssl?

   libssl should be listed after libQt5Network because the later one depends on the former one.

10. 
    jameshilliard commented at 4:33 am on October 26, 2018: contributor

    Any idea why the link order here only seems to cause issues on windows builds and not linux/osx?
11. 
    DrahtBot commented at 7:09 am on October 26, 2018: member

    Gitian builds for commit 754a00d55f30f6112a1b68cb0bec5d59565096d1 (master):

    • e53ac5a8e7f5b0f3d1fe80b8cfe7ba33... bitcoin-0.17.99-aarch64-linux-gnu-debug.tar.gz
    • 71f89c2aa1164480fe8945bfd75aead1... bitcoin-0.17.99-aarch64-linux-gnu.tar.gz
    • 923e17f52f6117362e7704c978f783f8... bitcoin-0.17.99-arm-linux-gnueabihf-debug.tar.gz
    • b63a5530902f6cf9c0a6eb9d9e7f3341... bitcoin-0.17.99-arm-linux-gnueabihf.tar.gz
    • c99efc3dfea1afc09913c840a9a0490b... bitcoin-0.17.99-i686-pc-linux-gnu-debug.tar.gz
    • c8d5ffb66c3b5516c39e156b5c33f75c... bitcoin-0.17.99-i686-pc-linux-gnu.tar.gz
    • c9113162a77f6ee2090491c837e0b143... bitcoin-0.17.99-osx-unsigned.dmg
    • 5fd4d8398f9ae67412bb2e2ed8dae2f5... bitcoin-0.17.99-osx64.tar.gz
    • 49b5a763c8db854315c0f530a596cd44... bitcoin-0.17.99-riscv64-linux-gnu-debug.tar.gz
    • 04222311f4c2d3bc56382000fbbdc8fd... bitcoin-0.17.99-riscv64-linux-gnu.tar.gz
    • 7d06e3e81d2c7ddbeafe2fd227005ef1... bitcoin-0.17.99-x86_64-linux-gnu-debug.tar.gz
    • 467230767f24502b17ce081ceec7664f... bitcoin-0.17.99-x86_64-linux-gnu.tar.gz
    • 153b0674fec532a66409328aa5fd4279... bitcoin-0.17.99.tar.gz
    • 0d520ee12ac2bdd7554d2272b7d839b9... bitcoin-linux-0.18-res.yml
    • b3fcb7fe2a7ecf35ad608713c9269a7b... bitcoin-linux-build.log
    • 33022b95077672e278550222e5cc4556... bitcoin-osx-0.18-res.yml
    • 8889e6f439cee491b6dd67d8aae28395... bitcoin-osx-build.log
    • 9fc8bcc497bcd002dfaf20358df1d4a2... bitcoin-win-build.log

    Gitian builds for commit 3dbc5bc94e8ebfdcfac57f76b987eb17a7a92aa5 (master and this pull):

    • 43eb3c2336c980c3c59844bb53d484fc... bitcoin-0.17.99-aarch64-linux-gnu-debug.tar.gz
    • 34dcce2e46527dd90cc82aa48d2f2098... bitcoin-0.17.99-aarch64-linux-gnu.tar.gz
    • 96201ee897e1343f1ccff0a48c5827a4... bitcoin-0.17.99-arm-linux-gnueabihf-debug.tar.gz
    • 94f24738a3bd255ff48d8456ed80f533... bitcoin-0.17.99-arm-linux-gnueabihf.tar.gz
    • 5ddb6c5b95339eade7e545159d5907ab... bitcoin-0.17.99-i686-pc-linux-gnu-debug.tar.gz
    • 1ff50e6ce9688b023e2d12daf2ae36b3... bitcoin-0.17.99-i686-pc-linux-gnu.tar.gz
    • ccc49a0a732ad9ce07ec837ce0f7a357... bitcoin-0.17.99-osx-unsigned.dmg
    • bc4c496aa96a8c41fef6b15ab7a27830... bitcoin-0.17.99-osx64.tar.gz
    • c79ee6c5fde5525999e8c0f8985be5b3... bitcoin-0.17.99-riscv64-linux-gnu-debug.tar.gz
    • e7f02110cc4af372bf466206b459f0c1... bitcoin-0.17.99-riscv64-linux-gnu.tar.gz
    • 47bb4da5f3075d01e383d35a7f94cf0f... bitcoin-0.17.99-win32-debug.zip
    • dc138a7afcb222e267f2033a275a833e... bitcoin-0.17.99-win32-setup-unsigned.exe
    • c38fd2d235e5a5eb73e05afef2957236... bitcoin-0.17.99-win32.zip
    • 0d3d8f83631794378332c971c574a1ed... bitcoin-0.17.99-win64-debug.zip
    • 117a3ec4a5a371b5e4228e23f4f8223b... bitcoin-0.17.99-win64-setup-unsigned.exe
    • e47ace23ad3db4e287386bc4fc11e9b0... bitcoin-0.17.99-win64.zip
    • b5be53226a273761b3d7a0700dc75896... bitcoin-0.17.99-x86_64-linux-gnu-debug.tar.gz
    • 7ec8d952a5b633b85fbb8a397d3ee979... bitcoin-0.17.99-x86_64-linux-gnu.tar.gz
    • 01d9bad25b1525499ba9ac3fe9faca74... bitcoin-0.17.99.tar.gz
    • 9d421d1fea8ba62b79dee2b9fa85a0c4... bitcoin-linux-0.18-res.yml
    • 350d90ed90b64e122845ac555df9fd34... bitcoin-linux-build.log
    • 5aba22220f1f051aed591011640be27f... bitcoin-osx-0.18-res.yml
    • 7c89651660556de6ede3d7527b544530... bitcoin-osx-build.log
    • 03841f0ad96fd7689c319889709c6b1b... bitcoin-win-0.18-res.yml
    • 572e9164c2b36b908f92211280a84300... bitcoin-win-build.log
12. DrahtBot removed the label Needs gitian build on Oct 26, 2018
13. MarcoFalke merged this on Oct 26, 2018
14. MarcoFalke closed this on Oct 26, 2018

    ---

15. MarcoFalke referenced this in commit ae85c8d28b on Oct 26, 2018
16. ken2812221 deleted the branch on Nov 3, 2018
17. dzutto referenced this in commit 167994195f on Aug 19, 2021
18. dzutto referenced this in commit 866d73c328 on Aug 19, 2021
19. dzutto referenced this in commit 6b7b7d37de on Aug 19, 2021
20. dzutto referenced this in commit 2c94189459 on Aug 23, 2021
21. dzutto referenced this in commit d0b7b14ad4 on Aug 26, 2021
22. dzutto referenced this in commit b73497114a on Aug 26, 2021
23. dzutto referenced this in commit 62535a0383 on Aug 27, 2021
24. PastaPastaPasta referenced this in commit b9df9815ba on Aug 29, 2021
25. DrahtBot locked this on Sep 8, 2021

Contributors
ken2812221 laanwj MarcoFalke ryanofsky jameshilliard DrahtBot

Labels
Build system