In cron job (https://travis-ci.org/bitcoin/bitcoin/builds/445823485), the functional tests would fail due to silent for 10 mins.
After applying this patch, we con't see any extra characters printed on screen but also avoid timeout (https://travis-ci.org/ken2812221/bitcoin/builds/445981698)
For this reason the test runner prints . every so few seconds, but somehow—that's no longer enough?
This is probably due to if self.logging_level == logging.DEBUG: from #14504. Imo that condition can be removed.
<!--e57a25ab6845829454e8d69fc972939a-->No more conflicts as of last run.
@MarcoFalke Is this what you mean or just remove the if condition to always print .?
Previously there was no condition, and it would always print: https://github.com/bitcoin/bitcoin/pull/14504/files?w=1#diff-a5b9b84e3a3387476629e74ddb227a7eR502
Not sure why that got added.
@ken2812221 don't you have to kill the waiting at some point since you put it on background? Also I think that travis has a 10m timeout, so printing every 9m should cut it. I've done something like this to avoid it while running the tests...
if [ "$RUN_TESTS" = "true" ]; then
while sleep 9m; do echo "=====[ $SECONDS seconds still running ]====="; done &
make $MAKEJOBS check VERBOSE=1
kill %1
fi
Previously there was no condition, and it would always print: https://github.com/bitcoin/bitcoin/pull/14504/files?w=1#diff-a5b9b84e3a3387476629e74ddb227a7eR502
Not sure why that got added.
To be coherent with --quiet option "only print results summary and failure logs".
@ken2812221 Maybe we can add the --dots option to show the dots. So the travis command could be
DOCKER_EXEC test/functional/test_runner.py --combinedlogslen=4000 --coverage --quiet --failfast --dots ${extended};
or the --travis option.
499 | - print(clearline, end='', flush=True) 500 | - dot_count = 0 501 | return TestResult(name, status, int(time.time() - start_time)), testdir, stdout, stderr 502 | - if self.logging_level == logging.DEBUG: 503 | - print('.', end='', flush=True) 504 | - dot_count += 1
I think it was nice to have some indicator that something was running. I'd prefer to keep it.
I agree: running functional tests, without any progress indicator, it's not a good incentive to run functional tests.
utACK 2e4435c
442 | @@ -441,7 +443,7 @@ class TestHandler: 443 | Trigger the test scripts passed in via the list. 444 | """ 445 | 446 | - def __init__(self, num_tests_parallel, tests_dir, tmpdir, test_list=None, flags=None, logging_level=logging.DEBUG): 447 | + def __init__(self, num_tests_parallel, tests_dir, tmpdir, test_list=None, flags=None, logging_level=logging.DEBUG, dots=False):
self.logging_level is now unused. I'd slightly prefer to remove it.
224 | @@ -225,6 +225,7 @@ def main(): 225 | parser.add_argument('--quiet', '-q', action='store_true', help='only print results summary and failure logs') 226 | parser.add_argument('--tmpdirprefix', '-t', default=tempfile.gettempdir(), help="Root directory for datadirs") 227 | parser.add_argument('--failfast', action='store_true', help='stop execution after the first test failure') 228 | + parser.add_argument('--dots', action='store_true', help='print dots while testing to avoid silence timeout on travis-ci.')
Is it really necessary to add an option to enable a feature that should be on by default? I think the average user would prefer to see dots without having to enable them by typing --dots every time.
224 | @@ -225,6 +225,7 @@ def main():
225 | parser.add_argument('--quiet', '-q', action='store_true', help='only print results summary and failure logs')
parser.add_argument('--quiet', '-q', action='store_true', help='only print dots, results summary and failure logs')
Could just add dots here and remove the other option?
Sorry for nitpicking this trivial change to death. Feel free to ignore my feedback.
@MarcoFalke Now it print dots by default.
utACK 4bd125fff080d1d1f20d0259836d55bb685be6d2
utACK 4bd125f
Seems reasonable. The whole point of quiet mode was to not fill the screen with output. Now that the dots erase themselves after each test, that's no longer an issues.
Tested ACK 4bd125fff080d1d1f20d0259836d55bb685be6d2