If a node has not announced a tx at all, then it should respond to getdata messages for that tx with notfound, to avoid leaking tx origination privacy.
In the future this could be adjusted such that a node responds with notfound when a tx has not been announced to us, but that seems to be a more involved change. See e.g. https://github.com/jnewbery/bitcoin/commits/pr14220.1
Concept ACK. Great test.
1238 | + 1239 | + def __init__(self, vec=None): 1240 | + if vec is None: 1241 | + self.vec = [] 1242 | + else: 1243 | + self.vec = vec
nit: more concise (if not exactly equivalent) as self.vec = vec or []
I think Marco's version is clearer.
24 | + def skip_test_if_missing_module(self): 25 | + self.skip_if_no_wallet() 26 | + 27 | + def run_test(self): 28 | + gen_node = self.nodes[0] # The block and tx generating node 29 | + gen_node.generate(1)
Should we use generate RPC in tests at all after #14299 ?
generate() is now a method in TestNode() that aliases to the generatetoaddress RPC
Understood. That was a neat way to do things .
25 | + self.skip_if_no_wallet() 26 | + 27 | + def run_test(self): 28 | + gen_node = self.nodes[0] # The block and tx generating node 29 | + gen_node.generate(1) 30 | + self.sync_all()
I am new here, but is sync_all() necessary when there is only 1 node?
Entirely correct! This can be removed
If a node has not announced a tx at all, then it should respond to
getdata messages for that tx with notfound, to avoid leaking tx
origination privacy.
1231 | @@ -1232,6 +1232,23 @@ def __repr__(self): 1232 | return "msg_mempool()" 1233 | 1234 | 1235 | +class msg_notfound: 1236 | + __slots__ = ("vec")
This should be __slots__ = ("vec",) to force tuple instead of str :-)
Ugh, I always get this wrong. Thx
Tested ACK fa78a2fc670d7162d6ba6d432188da6d6e5288ac
Tested ACK fa78a2fc670d7162d6ba6d432188da6d6e5288ac
