qt: Cleanup textInteractionFlags for QLabel #14577

1. 
   hebasto commented at 10:01 pm on October 25, 2018: member

   Qt::LinksAccessibleByMouse removed for all label not containing links.

   Qt::TextSelectableByKeyboard removed for all labels due to showing a text cursor even after leaving the label (for all platforms):

2. Cleanup `textInteractionFlags` for `QLabel`

   Qt::TextSelectableByMouse - keep unchanged.
   Qt::TextSelectableByKeyboard - removed due to showing a text cursor even
   after leaving the label.
   Qt::LinksAccessibleByMouse - used only by `helpmessagedialog.ui`.

   e4f00c2f3b
3. fanquake added the label GUI on Oct 25, 2018
4. 
   promag commented at 8:50 am on October 26, 2018: member

   utACK e4f00c2.

   showing a text cursor even after leaving the label

   Nice, tested this on macOS.

5. 
   fanquake commented at 7:44 am on October 28, 2018: member

   tACK e4f00c2

   There’s one usage of LinksAccessibleByMouse left in helpmessagedialog.ui, because the help message dialog is used to display the About screen, which contains clickable links.

   The only other flag we use (including TextSelectableByMouse) is a single instance of NoTextInteraction in debugwindow.ui.

   For reference all Qt::TextInteractionFlags are listed here.

   Only other thought is if this has some sort of effect to Accessibility, however I can’t test that.

   Before:

   After:

6. 
   laanwj commented at 3:14 pm on November 1, 2018: member

   I’m not sure this is a good idea—why disallow selecting by keyboard?

   Only other thought is if this has some sort of effect to Accessibility, however I can’t test that.

   Exactly, might be that someone is not able to use a mouse that well, being able to tab through fields and select by keyboard could be a great help?

7. 
   hebasto commented at 7:47 pm on November 1, 2018: member

   @laanwj

   Exactly, might be that someone is not able to use a mouse that well, being able to tab through fields and select by keyboard could be a great help?

   In fact, someone is not able to tab through fields on master. Because those fields have not Qt::TabFocus flag set.

   Therefore, IMO, this PR does not touch accessibility in any way, cleans up code and removes visual artifacts in GUI.

8. 
   jonasschnelli commented at 8:59 am on November 13, 2018: contributor

   Tested ACK. I think selecting by keyboard would be okay/desirable if you can access the fields by keyboard (which is not possible now). Bringing it back with full accessibility support (or call it “keyboard” mode) is still possible.
9. 
   laanwj commented at 12:54 pm on November 14, 2018: member

   In fact, someone is not able to tab through fields on master. Because those fields have not Qt::TabFocus flag set.

   What about enabling that, then? Move in the right direction instead of the wrong one.

10. 
    hebasto commented at 4:23 pm on November 26, 2018: member

    @laanwj Thank you for your review. Closed in favour of #14810.
11. hebasto closed this on Nov 26, 2018

    ---

12. hebasto deleted the branch on Jan 18, 2020
13. laanwj referenced this in commit d626a3be31 on Jul 15, 2020
14. sidhujag referenced this in commit 6db274eaa0 on Jul 16, 2020
15. PastaPastaPasta referenced this in commit 3b0144beeb on Sep 21, 2021
16. kittywhiskers referenced this in commit f8470b479a on Oct 12, 2021
17. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto promag fanquake laanwj jonasschnelli

Labels
GUI