gui: explicitly disable "Dark Mode" appearance on macOS #14593

1. 
   fanquake commented at 1:49 PM on October 28, 2018: member

   Bitcoin Core's gui is pretty broken for a someone using macOS in "Dark Mode"; the biggest issue being lots of white text on a white background, leaving most inputs, the rpc console etc unusable.

   This is likely something we'll have to wait for Qt to fix/support, so it's probably easiest to just disable for now, rather than provide a broken UI; see screenshots below. This issue might not have come up much yet, given the issues with the 0.17.0 dmg.

   Apple documentation on "Opting out of Dark Mode" is here.

   If you need extra time to work on your app's Dark Mode support, you can temporarily opt out by including the NSRequiresAquaSystemAppearance key (with a value of true) in your app’s Info.plist file. Setting this key to true causes the system to ignore the user's preference and always apply a light appearance to your app.

   Related upstream tickets:

   • Qt Applications are not usable under macOS Mojave with dark theme
   • macOS 10.14 Mojave Support

   Screenshots:

2. gui: explicitly disable "Dark Mode" appearance on macOS cf2f4306fe
3. fanquake added the label GUI on Oct 28, 2018
4. fanquake added the label macOS on Oct 28, 2018
5. 
   DrahtBot commented at 3:20 PM on October 28, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->Reviewers, this pull request conflicts with the following ones:

   • #12783 (macOS: disable AppNap during sync by krab)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   jonasschnelli commented at 7:14 PM on October 28, 2018: contributor

   Concept ACK cf2f4306fe26305b24bba8833af845ada3a42ec8

7. 
   ch4ot1c commented at 2:24 AM on October 29, 2018: contributor

   Concept ACK

8. 
   hebasto commented at 7:45 PM on October 29, 2018: member

   Concept ACK. Additional ref: Qt Examples Dark Mode Audit (Mojave)

9. 
   fanquake commented at 7:06 AM on October 31, 2018: member

   I did some testing with 29f429dc7 and Qt 5.12 (HEAD 82ca14f), and the situation is improved somewhat, but still broken. So I'd still suggest we explicitly disable this for now, and back-port to the 0.17.1 branch, so we don't continue to provide a broken UI (for "Dark Mode" users) there.

   

   

   

10. laanwj added this to the milestone 0.17.1 on Nov 1, 2018
11. laanwj added the label Needs backport on Nov 1, 2018
12. 
    laanwj commented at 1:28 PM on November 1, 2018: member

    yess seems like a no-brainer until there's actual support for this, thanks

    utACK cf2f4306fe26305b24bba8833af845ada3a42ec8

13. laanwj merged this on Nov 1, 2018
14. laanwj closed this on Nov 1, 2018

    ---

15. laanwj referenced this in commit 08a57d51e9 on Nov 1, 2018
16. fanquake referenced this in commit df5131bd41 on Nov 29, 2018
17. 
    fanquake commented at 4:35 AM on November 29, 2018: member

    Backported in #14835.

18. fanquake removed the label Needs backport on Nov 29, 2018
19. fanquake deleted the branch on Nov 29, 2018
20. MarcoFalke referenced this in commit d8bc0ce1da on Nov 30, 2018
21. konez2k referenced this in commit 02635ce3ee on Feb 28, 2020
22. jasonbcox referenced this in commit 129caaf0bd on Nov 9, 2020
23. MarcoFalke referenced this in commit 3bcd278aa6 on Mar 29, 2021
24. MarcoFalke locked this on Sep 8, 2021

Milestone
0.17.1