docs: Less confusing documentation for `torpassword` #14609

 109 | @@ -110,8 +110,8 @@ are seen with `-debug=tor` they can be resolved by adding both the user running
 110 |  the user running bitcoind to the same group and setting permissions appropriately. On
 111 |  Debian-based systems the user running bitcoind can be added to the debian-tor group,
 112 |  which has the appropriate permissions. An alternative authentication method is the use
 113 | -of the `-torpassword` flag and a `hash-password` which can be enabled and specified in
 114 | -Tor configuration.
 115 | +of the `-torpassword=hashpassword` option. The `hashpassword` can be enabled and specified in
 116 | +Tor configuration under the `HashedControlPassword` option.

laanwj commented at 5:12 PM on October 31, 2018:

it's an improvement but still not fully clear as to what actually needs to be done to set up tor password authentication. to be clear:

• bitcoind's torpassword takes the unhashed password
• tor's configuration HashedControlPassword has a hashed password IIRC they have a command that can either hash a password for their configuration file, or generate a password and show both the actual and hashed password

the way that this is worded, it sounds like bitcoind's argument takes the hashes password too

blob42 commented at 9:49 AM on November 2, 2018:

I just pushed an other change that adds more details on the relation between password and HashedControlPassword.