Include full version number in released file names #14612

1. 
   achow101 commented at 7:04 PM on October 30, 2018: member

   As noted on IRC, the filenames of the gitian build results do not contain the 4th digit of the version number if it has one, e.g. 0.17.0.1 produces files with the number 0.17.0. Furthermore, when RC's are built, the resulting filenames are of the release version and do not include rc in them. This occurs because configure.ac is written to create version numbers of the form major.minor.rev instead of major.minor.rev.build and without any rc version as it does not handle rc numbers.

   This PR changes configure.ac to include the build number if it is greater than 0. It will also include the rc number if it is greater than 0. So the filenames of the gitian builds will now contain the full version number.

   This behavior can be tested by setting _CLIENT_VERSION_BUILD and _CLIENT_VERSION_RC to non-zero values and then doing make dist. A tar file should be created with the correct versioning.

2. build: if VERSION_BUILD is non-zero, include it in the package version

   When the build number (CLIENT_VERSION_BUILD) is non-zero, we want
   to include that in the package version number so the resulting binaries
   are named with the correct version.

   895e6bbb22
3. build: include rc number in version number 04b0bc7425
4. 
   luke-jr commented at 8:17 PM on October 30, 2018: member

   So it would show 0.17.0.1rc1 if that was the version?

   Might be nice to actually use the full version number generated from the tag, so non-tag builds get the commit hash in there...

5. MarcoFalke added the label Build system on Oct 30, 2018
6. MarcoFalke added the label Needs gitian build on Oct 30, 2018
7. 
   achow101 commented at 12:33 AM on October 31, 2018: member

   So it would show 0.17.0.1rc1 if that was the version?

   It would only show in the gitian produced files. This shouldn't effect what users would see from -version or in the About window.

8. DrahtBot removed the label Needs gitian build on Oct 31, 2018
9. 
   laanwj commented at 5:24 PM on October 31, 2018: member

   Concept ACK

   • maybe not for this PR, but would also make sense to show the RC information in the about: dialog and the log
   • probably needs an update to doc/release-process.md to update this new setting between rcs
   • this naming might need updates at the side of bitcoin.org (@wbnns) and bitcoincore.org (@harding) though as RCs are never linked from the webpage, and .dot releases are extremely are, that might amount to nothing or at least not be urgent. Normal releases will not change name, correct?
10. 
    harding commented at 8:11 PM on October 31, 2018: contributor

    For BitcoinCore.org, as @laanwj mentions, the regular content part of the website doesn't currently have any pages that link directly to RCs, so no changes are necessary as long as the final release files continue to use the same naming scheme.

11. laanwj added this to the milestone 0.18.0 on Nov 1, 2018
12. 
    wbnns commented at 12:41 PM on November 1, 2018: none

    Should be okay for bitcoin.org as well, thanks.

13. Update release-process.md to include RC version bumping 75a4bf699f
14. 
    achow101 commented at 3:33 PM on November 1, 2018: member

    I've updated release-process.md to say that CLIENT_VERSION_RC needs to be updated before each RC.

    Normal releases will not change name, correct?

    Correct.

15. 
    laanwj commented at 3:49 PM on November 1, 2018: member

    @harding @wbnns thanks for weighing in

    utACK 75a4bf699fa6bdefa1b3d8cd405ea822d6ee01c0

16. 
    laanwj commented at 1:06 PM on November 5, 2018: member

    @theuni I suppose you're ok with this?

17. laanwj merged this on Nov 23, 2018
18. laanwj closed this on Nov 23, 2018

    ---

19. laanwj referenced this in commit 1d3af69fd0 on Nov 23, 2018
20. MarcoFalke deleted a comment on Nov 23, 2018
21. random-zebra referenced this in commit 0f92bf8e17 on Nov 25, 2019
22. lukechilds referenced this in commit 687f09aa0c on Dec 11, 2019
23. lukechilds referenced this in commit 18cc55ea65 on Dec 11, 2019
24. TheHolyRoger referenced this in commit e770bd60c3 on Jul 26, 2020
25. Munkybooty referenced this in commit 0f397a3adf on Jul 29, 2021
26. Munkybooty referenced this in commit 3a16752aa6 on Jul 29, 2021
27. Munkybooty referenced this in commit bc6ad8d569 on Aug 3, 2021
28. Munkybooty referenced this in commit b402cfe324 on Aug 5, 2021
29. Munkybooty referenced this in commit 76206a62bd on Aug 8, 2021
30. Munkybooty referenced this in commit ca8bbdf247 on Aug 9, 2021
31. Munkybooty referenced this in commit c5d4a69ce0 on Aug 11, 2021
32. 5tefan referenced this in commit 5a4ac36c73 on Aug 12, 2021
33. MarcoFalke locked this on Sep 8, 2021

Milestone
0.18.0