build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString #14701

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:add-build-version-to-info-plist changing 1 files +1 −1
  1. fanquake commented at 9:54 AM on November 10, 2018: member

    As mentioned in #14697, if you download the 0.17.0.1 dmg, and inspect the .app bundle, the version in the GetInfo string reads 0.17.0, which is confusing given you're expecting 0.17.0.1: <img width="391" alt="0 17 0 1" src="https://user-images.githubusercontent.com/863730/48300032-fbb54b00-e510-11e8-9bcd-77e1fffffc63.png">

    This PR adds CLIENT_VERSION_BUILD to the string, so that the full version number is displayed, i.e: <img width="327" alt="this pr" src="https://user-images.githubusercontent.com/863730/48300015-7893f500-e510-11e8-98b9-80424719a082.png">

  2. build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString 8e209340c8
  3. fanquake added the label macOS on Nov 10, 2018
  4. fanquake added the label Build system on Nov 10, 2018
  5. laanwj commented at 12:35 PM on November 14, 2018: member

    Concept ACK. Might want to wait until #14612 is merged so that RC level (of appropriate) can be included as well.

  6. DrahtBot added the label Needs gitian build on Nov 20, 2018
  7. DrahtBot removed the label Needs gitian build on Nov 21, 2018
  8. laanwj commented at 9:09 AM on November 23, 2018: member

    Might want to wait until #14612 is merged so that RC level (of appropriate) can be included as well.

    FYI #14612 was merged

  9. MarcoFalke deleted a comment on Nov 23, 2018
  10. jonasschnelli commented at 11:23 PM on December 9, 2018: contributor

    utACK 8e209340c85fc2493d7d1d7affe7e316bb613cbd

  11. jonasschnelli commented at 12:59 AM on December 10, 2018: contributor

    Tested via gitian build: https://bitcoin.jonasschnelli.ch/build/908

    Result: <img width="210" alt="bildschirmfoto 2018-12-09 um 14 57 55" src="https://user-images.githubusercontent.com/178464/49705529-eb04fd00-fbc2-11e8-942b-99a27a4b2c8a.png">

  12. laanwj merged this on Dec 12, 2018
  13. laanwj closed this on Dec 12, 2018
  14. laanwj referenced this in commit edc2822b9d on Dec 12, 2018
  15. fanquake deleted the branch on Dec 15, 2018
  16. PastaPastaPasta referenced this in commit 1a119f9b88 on Feb 5, 2019
  17. UdjinM6 referenced this in commit 90bb3ca2f6 on Feb 12, 2019
  18. codablock referenced this in commit 2db1af6eeb on Mar 7, 2019
  19. codablock referenced this in commit 1cc47ebcd0 on Mar 7, 2019
  20. MIPPL referenced this in commit 1d6091df8e on May 26, 2019
  21. core-code commented at 10:52 AM on November 25, 2019: none

    this has been going completely into the wrong direction. the 'CFBundleGetInfoString' has been deprecated for more than 10 years (!) and needs to be removed completely and not updated.

    (if you need some copyright information it should be added to the 'NSHumanReadableCopyright' field)

    meanwhile the 'real' version numbers embedded into the app are still broken. if you download version '0.19.0.1' the version strings are still cropped:

    CFBundleShortVersionString: 0.19.0 CFBundleVersion: 0.19.0

    both are wrong.

  22. random-zebra referenced this in commit 0f92bf8e17 on Nov 25, 2019
  23. laanwj commented at 8:15 AM on November 29, 2019: member

    So looks like the versions are still cropped. Can anyone verify?

  24. Sjors commented at 8:50 AM on November 29, 2019: member

    Not sure where to look, these all look fine on Catalina:

    <img width="492" alt="Schermafbeelding 2019-11-29 om 09 49 22" src="https://user-images.githubusercontent.com/10217/69856337-b4ba0500-128d-11ea-8b8b-804dc3b5e830.png">

    <img width="465" alt="Schermafbeelding 2019-11-29 om 09 49 39" src="https://user-images.githubusercontent.com/10217/69856347-b7b4f580-128d-11ea-90bd-745d0824552d.png">

    <img width="267" alt="Schermafbeelding 2019-11-29 om 09 49 56" src="https://user-images.githubusercontent.com/10217/69856352-bbe11300-128d-11ea-92fc-f4bbcc318c84.png">

  25. core-code commented at 11:07 AM on November 29, 2019: none

    the screenshots from inside the app aren't useful. they can show anything they want and do not necessarily have a connection to the real version numbers of the app, i.e. the one the operating system knows about and e.g. uses to determine which is the newest version if multiple versions are installed.

    the real version numbers are the CFBundleShortVersionString and especially the CFBundleVersion entries in the Info.plist file.

    the screenshot from the Finder proves what i've been saying above. you are including the 'CFBundleGetInfoString' in your plist. this has been deprecated for more than 10 years. so, in the Finder you are just seeing this deprecated string instead of the real version numbers. those are still cropped: <img width="720" alt="Screenshot 2019-11-29 at 12 06 55" src="https://user-images.githubusercontent.com/1261954/69865149-be993380-12a0-11ea-8237-792fae4acb36.png">

  27. core-code commented at 12:07 PM on November 29, 2019: none

    so, if you change CFBundleShortVersionString and CFBundleVersion to <string>@CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_REVISION@.@CLIENT_VERSION_BUILD@</string> and remove CFBundleGetInfoString and add NSHumanReadableCopyright then things should be good ;)

  28. MarcoFalke commented at 7:40 PM on December 3, 2019: member

    @core-code Please open a new issue or pull request for this

  29. fanquake referenced this in commit 86fd77f8fe on Dec 3, 2019
  30. fanquake referenced this in commit c0bc453135 on Dec 31, 2019
  31. laanwj referenced this in commit 01668839de on Feb 5, 2020
  32. sidhujag referenced this in commit 3a0e772abd on Feb 9, 2020
  33. HashUnlimited referenced this in commit 74c996598c on Apr 17, 2020
  34. sidhujag referenced this in commit d2465f2ffd on Nov 10, 2020
  35. kittywhiskers referenced this in commit 73edec8752 on Jul 15, 2021
  36. kittywhiskers referenced this in commit bffe6e2325 on Jul 15, 2021
  37. kittywhiskers referenced this in commit 3279a32558 on Jul 20, 2021
  38. kittywhiskers referenced this in commit d15c47c037 on Jul 20, 2021
  39. kittywhiskers referenced this in commit dd78d5c3bf on Jul 20, 2021
  40. kittywhiskers referenced this in commit be4893c41f on Aug 1, 2021
  41. kittywhiskers referenced this in commit 55b183ff94 on Aug 24, 2021
  42. kittywhiskers referenced this in commit 2f71533886 on Aug 24, 2021
  43. kittywhiskers referenced this in commit a1f7af068a on Aug 25, 2021
  44. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakelaanwjjonasschnellicore-codeSjorsMarcoFalke
Labels
macOSBuild system
Linked (view graph)
#14697 bitcoin core 0.17.0.1 on OSX shows up as 0.17.0 in Finder's 'Get Info"#17660 build: remove deprecated key from macOS Info.plist
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 12:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me