Former code sent '0' as nonce, which was serialized as 32-bit.
Fixes #1455.
Use a 64-bit nonce in ping #1463
pull sipa wants to merge 1 commits into bitcoin:master from sipa:fix_1455 changing 1 files +2 −1-
sipa commented at 4:33 PM on June 14, 2012: member
-
c971112dfa
Use a 64-bit nonce in ping
Former code sent '0' as nonce, which was serialized as 32-bit.
-
luke-jr commented at 4:40 PM on June 14, 2012: member
Why not just (uint64)0 ?
-
sipa commented at 4:41 PM on June 14, 2012: member
Giving the parameter a name is more readable, imho, and I doubt it makes any difference performance-wise.
-
luke-jr commented at 4:44 PM on June 14, 2012: member
ACK
-
gmaxwell commented at 4:48 PM on June 14, 2012: contributor
ACK, works for me.
- gmaxwell referenced this in commit 194ea3186a on Jun 14, 2012
- gmaxwell merged this on Jun 14, 2012
- gmaxwell closed this on Jun 14, 2012
- coblee referenced this in commit 4f1da1acf7 on Jul 17, 2012
- suprnurd referenced this in commit 39750439bf on Dec 5, 2017
- lateminer referenced this in commit 976f46d6e1 on May 6, 2020
- DrahtBot locked this on Sep 8, 2021
