Tests: Fix a comment #14632

pull fridokus wants to merge 1 commits into bitcoin:master from fridokus:typo_fix changing 1 files +2 −3

fridokus commented at 3:26 PM on November 1, 2018: contributor

Fix a comment that was false
Tests: Fix a comment 086fc83571
DrahtBot commented at 4:52 PM on November 1, 2018: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14606 (Tests: Consistency changes in comments by fridokus)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in test/functional/mempool_resurrect.py:54 in 9fa53105af outdated
```
  51 | @@ -52,7 +52,7 @@ def run_test(self):
  52 |          for node in self.nodes:
  53 |              node.invalidateblock(blocks[0])
  54 |  
  55 | -        # mempool should be empty, all txns confirmed
  56 | +        # All txns should be back in mempool with 0 confirmations
```
MarcoFalke commented at 4:56 PM on November 1, 2018:

Could remove the comment, since it is mentioned two lines up already?

fridokus commented at 8:16 PM on November 1, 2018:

Removed the first occurrence instead, to put the information closer to where it's relevant.
MarcoFalke commented at 8:53 PM on November 1, 2018: member

Please keep your commits squashed for trivial changes. See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits
fanquake added the label Tests on Nov 1, 2018
fridokus force-pushed on Nov 2, 2018
fridokus commented at 7:55 AM on November 2, 2018: contributor

Squashed the commits
fanquake commented at 10:40 AM on November 5, 2018: member

utACK 086fc83
MarcoFalke referenced this in commit 6b8d0a2164 on Nov 5, 2018
MarcoFalke merged this on Nov 5, 2018
MarcoFalke closed this on Nov 5, 2018
fridokus deleted the branch on Nov 6, 2018
MarcoFalke referenced this in commit e1f56caa66 on Nov 19, 2018
MarcoFalke referenced this in commit 96f15e8bb3 on Nov 28, 2018
deadalnix referenced this in commit a05bd47c8e on Jun 16, 2020
ftrader referenced this in commit b637a9b04e on Aug 17, 2020
PastaPastaPasta referenced this in commit e6e3bbb436 on Jun 27, 2021
PastaPastaPasta referenced this in commit 5ea1760947 on Jun 28, 2021
PastaPastaPasta referenced this in commit 8207c348e2 on Jun 29, 2021
PastaPastaPasta referenced this in commit 7434c4142f on Jul 1, 2021
PastaPastaPasta referenced this in commit 8c791da8ad on Jul 1, 2021
PastaPastaPasta referenced this in commit 3d7e6a888e on Jul 1, 2021
PastaPastaPasta referenced this in commit befb4d400f on Jul 3, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Tests: Fix a comment #14632

Conflicts