RPC: add weight to mempool entry output #14649

1. 
   luke-jr commented at 7:30 pm on November 3, 2018: member

   Rebased and fixed outstanding issues in #11256

   Also removed some unnecessary refactoring to simplify review

2. RPC: add weight to mempool entry output e4c8c39632
3. qa: Add RPC tests for weight in mempool entry a250df1602
4. qa: Add more RPC tests for wtxid in mempool entry, clarify comment 092defc216
5. luke-jr force-pushed on Nov 3, 2018
6. 
   DrahtBot commented at 8:29 pm on November 3, 2018: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15637 (rpc: Rename size to vsize in mempool related calls by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. fanquake added the label RPC/REST/ZMQ on Nov 3, 2018
8. 
   meshcollider commented at 1:31 am on November 4, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/14649/commits/092defc216c9fe2a6d32bd670a5f5215c143a48c
9. 
   promag commented at 6:09 pm on November 4, 2018: member

   utACK 092defc. Could have release note.
10. 
    conscott commented at 8:48 am on November 6, 2018: contributor

    Tested ACK 092defc216c9fe2a6d32bd670a5f5215c143a48c
11. 
    promag commented at 11:29 am on November 12, 2018: member

    @luke-jr the following also get weight key in the result:

    • getrawmempool, getmempoolancestors and getmempooldescendants with verbose=true
    • /rest/mempool/contents.json.

    Do you mind adding tests for those (at least test it’s numeric) and add release notes?

12. 
    DrahtBot commented at 5:55 pm on March 26, 2019: member
13. DrahtBot added the label Needs rebase on Mar 26, 2019
14. fanquake added the label Needs release note on Jun 17, 2019
15. 
    fanquake commented at 9:15 am on June 17, 2019: member

    Given this had utACKs, @luke-jr would you like to rebase and add some release notes.
16. fanquake added the label Waiting for author on Jun 19, 2019
17. 
    fanquake commented at 3:50 am on August 19, 2019: member

    I’ve rebased and added release-notes in #16647.
18. fanquake closed this on Aug 19, 2019

    ---

19. fanquake removed the label Needs rebase on Aug 19, 2019
20. fanquake removed the label Waiting for author on Aug 19, 2019
21. MarcoFalke referenced this in commit 70b12af87e on Aug 20, 2019
22. sidhujag referenced this in commit 4bc70112f1 on Aug 22, 2019
23. fanquake removed the label Needs release note on Aug 23, 2019
24. DrahtBot locked this on Dec 16, 2021

Contributors
luke-jr DrahtBot meshcollider promag conscott fanquake

Labels
RPC/REST/ZMQ