RPC: add weight to mempool entry output #14649

pull luke-jr wants to merge 3 commits into bitcoin:master from luke-jr:rpc_mempoolentry_weight changing 2 files +24 −1

luke-jr commented at 7:30 PM on November 3, 2018: member

Rebased and fixed outstanding issues in #11256

Also removed some unnecessary refactoring to simplify review
RPC: add weight to mempool entry output e4c8c39632
qa: Add RPC tests for weight in mempool entry a250df1602
qa: Add more RPC tests for wtxid in mempool entry, clarify comment 092defc216
luke-jr force-pushed on Nov 3, 2018
DrahtBot commented at 8:29 PM on November 3, 2018: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15637 (rpc: Rename size to vsize in mempool related calls by fanquake)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake added the label RPC/REST/ZMQ on Nov 3, 2018
meshcollider commented at 1:31 AM on November 4, 2018: contributor

utACK https://github.com/bitcoin/bitcoin/pull/14649/commits/092defc216c9fe2a6d32bd670a5f5215c143a48c
promag commented at 6:09 PM on November 4, 2018: member

utACK 092defc. Could have release note.
conscott commented at 8:48 AM on November 6, 2018: contributor

Tested ACK 092defc216c9fe2a6d32bd670a5f5215c143a48c
promag commented at 11:29 AM on November 12, 2018: member
@luke-jr the following also get weight key in the result:
- getrawmempool, getmempoolancestors and getmempooldescendants with verbose=true
- /rest/mempool/contents.json.
Do you mind adding tests for those (at least test it's numeric) and add release notes?
DrahtBot commented at 5:55 PM on March 26, 2019: member

Needs rebase
DrahtBot added the label Needs rebase on Mar 26, 2019
fanquake added the label Needs release note on Jun 17, 2019
fanquake commented at 9:15 AM on June 17, 2019: member

Given this had utACKs, @luke-jr would you like to rebase and add some release notes.
fanquake added the label Waiting for author on Jun 19, 2019
fanquake commented at 3:50 AM on August 19, 2019: member

I've rebased and added release-notes in #16647.
fanquake closed this on Aug 19, 2019
fanquake removed the label Needs rebase on Aug 19, 2019
fanquake removed the label Waiting for author on Aug 19, 2019
MarcoFalke referenced this in commit 70b12af87e on Aug 20, 2019
sidhujag referenced this in commit 4bc70112f1 on Aug 22, 2019
fanquake removed the label Needs release note on Aug 23, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#11256 RPC: add weight to mempool entry output #16647 rpc: add weight to getmempoolentry output

RPC: add weight to mempool entry output #14649

Conflicts