qt: remove unused SECURE style #14655

1. 
   ken2812221 commented at 5:07 am on November 5, 2018: contributor

   SECURE style seem to be unused. According to the comment it do the same thing as -nodebuglogfile
2. qt: remove unused SECURE style 1687fc21c9
3. fanquake added the label GUI on Nov 5, 2018
4. 
   DrahtBot commented at 5:39 am on November 5, 2018: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

   Coverage

   Coverage	Change (pull 14655)	Reference (master)
   Lines	+0.0022 %	87.0960 %
   Functions	-0.0612 %	84.3822 %
   Branches	+0.0019 %	51.5722 %

   Updated at: 2018-11-05T21:07:19.026465.

5. 
   fanquake commented at 9:02 am on November 5, 2018: member

   tACK 1687fc2

   The single usage of the SECURE style was added in #5095, but was removed in #6388.

6. 
   promag commented at 10:18 am on November 5, 2018: member

   utACK 1687fc2.
7. 
   laanwj commented at 10:41 am on November 5, 2018: member

   should we be using this anywhere?
8. 
   ken2812221 commented at 4:04 pm on November 5, 2018: contributor

   should we be using this anywhere?

   The code is unused for a really long time. From the comment that I know that this is to not print debug log to file. The function can be replaced by gArgs.ForceSetArg IMO.

9. 
   MarcoFalke commented at 4:19 pm on November 5, 2018: member

   It is not meant as a global flag to print to the debug log, but rather a per-message flag to disable the printing for this message.
10. 
    laanwj commented at 8:50 am on November 6, 2018: member

    yes, I think it’s fair enough to respond “no, we have no use for this”, but I have the feeling that you misunderstand what it does. @MarcoFalke explains it well.
11. 
    jonasschnelli commented at 2:12 am on November 7, 2018: contributor

    Somehow this seems to be useful per message flag. I’m don’t mind if there is code options we don’t use at the moment for future leverage of using it at the right place. Agree with @laanwj about the should.
12. 
    ken2812221 commented at 3:00 am on November 7, 2018: contributor

    Closing. So we can keep this flag for the future sensitive messages that shouldn’t be stored in the debug log. It can only be displayed on screen.
13. ken2812221 closed this on Nov 7, 2018

    ---

14. ken2812221 deleted the branch on Nov 7, 2018
15. MarcoFalke locked this on Sep 8, 2021

Contributors
ken2812221 DrahtBot fanquake promag laanwj MarcoFalke jonasschnelli

Labels
GUI