qt: remove unused SECURE style #14655

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:qt-unused-secure changing 3 files +1 −11

ken2812221 commented at 5:07 AM on November 5, 2018: contributor

SECURE style seem to be unused. According to the comment it do the same thing as -nodebuglogfile
qt: remove unused SECURE style 1687fc21c9
fanquake added the label GUI on Nov 5, 2018
DrahtBot commented at 5:39 AM on November 5, 2018: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.

Coverage

Coverage Change (pull 14655) Reference (master)

Lines +0.0022 % 87.0960 %

Functions -0.0612 % 84.3822 %

Branches +0.0019 % 51.5722 %

<sup>Updated at: 2018-11-05T21:07:19.026465.</sup>
fanquake commented at 9:02 AM on November 5, 2018: member

tACK 1687fc2

The single usage of the SECURE style was added in #5095, but was removed in #6388.
promag commented at 10:18 AM on November 5, 2018: member

utACK 1687fc2.
laanwj commented at 10:41 AM on November 5, 2018: member

should we be using this anywhere?
ken2812221 commented at 4:04 PM on November 5, 2018: contributor

should we be using this anywhere?

The code is unused for a really long time. From the comment that I know that this is to not print debug log to file. The function can be replaced by gArgs.ForceSetArg IMO.
MarcoFalke commented at 4:19 PM on November 5, 2018: member

It is not meant as a global flag to print to the debug log, but rather a per-message flag to disable the printing for this message.
laanwj commented at 8:50 AM on November 6, 2018: member

yes, I think it's fair enough to respond "no, we have no use for this", but I have the feeling that you misunderstand what it does. @MarcoFalke explains it well.
jonasschnelli commented at 2:12 AM on November 7, 2018: contributor

Somehow this seems to be useful per message flag. I'm don't mind if there is code options we don't use at the moment for future leverage of using it at the right place. Agree with @laanwj about the should.
ken2812221 commented at 3:00 AM on November 7, 2018: contributor

Closing. So we can keep this flag for the future sensitive messages that shouldn't be stored in the debug log. It can only be displayed on screen.
ken2812221 closed this on Nov 7, 2018
ken2812221 deleted the branch on Nov 7, 2018
MarcoFalke locked this on Sep 8, 2021