[wallet] remove redundant KeyOriginInfo access, already done in CreateSig #14678

pull instagibbs wants to merge 2 commits into bitcoin:master from instagibbs:redundant_keypath changing 1 files +2 −9
  1. instagibbs commented at 3:56 PM on November 7, 2018: member

    This redundancy is confusing as it looks like pubkeyhashes are special in some way based on where it's called.

  3. instagibbs renamed this:
    remove redundant KeyOriginInfo access, already done in CreateSig
    [wallet] remove redundant KeyOriginInfo access, already done in CreateSig
    on Nov 7, 2018
  4. MarcoFalke added the label Wallet on Nov 7, 2018
  5. DrahtBot commented at 4:14 PM on November 7, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #13932 (Additional utility RPCs for PSBT by achow101)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. in src/script/sign.cpp:66 in 9ae01b994c outdated 
      63 | @@ -64,10 +64,6 @@ static bool GetPubKey(const SigningProvider& provider, SignatureData& sigdata, c
  64 |      }
  65 |      // Query the underlying provider
  66 |      if (provider.GetPubKey(address, pubkey)) {
    practicalswift commented at 8:06 AM on November 9, 2018:

    Use return provider.GetPubKey(address, pubkey); instead :-)

    instagibbs commented at 6:18 PM on November 12, 2018:

    good one, done.

  8. remove redundant KeyOriginInfo access, already done in CreateSig f7beb95a1f
  9. instagibbs force-pushed on Nov 12, 2018
  10. laanwj commented at 3:28 PM on November 13, 2018: member

    Is this redundant for all possible code paths that lead to GetPubKey?

  11. instagibbs commented at 3:34 PM on November 13, 2018: member

    @laanwj It's the only instance of it, yes.

  12. laanwj commented at 3:36 PM on November 13, 2018: member

    so this is SignStep that calls GetPubKey then CreateSig? I see, utACK https://github.com/bitcoin/bitcoin/pull/14678/commits/f7beb95a1f921ed292680fbd2f042b4bac73bf59

  13. GetPubKey: make sigdata const b81a186056
  14. instagibbs commented at 3:42 PM on November 13, 2018: member

    made sigdata const to make the intention of function clearer

  16. laanwj merged this on Nov 23, 2018
  17. laanwj closed this on Nov 23, 2018
  18. laanwj referenced this in commit 0595164dba on Nov 23, 2018
  19. deadalnix referenced this in commit c971f3dc0f on Jun 6, 2020
  20. linuxsh2 referenced this in commit cb4d543949 on Jul 29, 2021
  21. linuxsh2 referenced this in commit afcae8ff24 on Jul 30, 2021
  22. linuxsh2 referenced this in commit 9c27b383ae on Aug 3, 2021
  23. MarcoFalke locked this on Sep 8, 2021
Contributors
instagibbsDrahtBotmeshcolliderpracticalswiftlaanwj
Labels
Wallet
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me