build: Fix windows build error if `--disable-bip70` #14686

pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:fix-windows-disable-bip70 changing 1 files +4 −0
  1. ken2812221 commented at 9:10 PM on November 7, 2018: contributor

    Fix #14677 The SSL library seems to be used even if bip70 disabled on Windows.

  2. build: Fix windows build error if `--disable-bip70` 7a90b1b9d8
  3. MarcoFalke added this to the milestone 0.18.0 on Nov 7, 2018
  4. MarcoFalke added the label Build system on Nov 7, 2018
  5. MarcoFalke added the label Needs gitian build on Nov 7, 2018
  6. DrahtBot commented at 12:37 AM on November 8, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

  7. DrahtBot commented at 2:59 PM on November 8, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 11e1ac3ae08535cefbd8235a8deb6cd100bcb2b1 (master):

    Gitian builds for commit 67a71c284fea254928fe0ec5d59a39c3d2765a7d (master and this pull):

  8. DrahtBot removed the label Needs gitian build on Nov 8, 2018
  9. ryanofsky commented at 4:07 PM on November 8, 2018: member

    I think it would be preferable to add libssl to $(QT_LIBS) if it's a dependency of qt code.

    But this change seems fine as a workaround if needed, so utACK 7a90b1b9d8d3297959c2d339192d8c90fb632db6.

  10. MarcoFalke commented at 5:54 PM on November 8, 2018: member

    Going to merge this, since it has a tested ack in the linked issue.

  11. MarcoFalke merged this on Nov 8, 2018
  12. MarcoFalke closed this on Nov 8, 2018
  13. MarcoFalke referenced this in commit e52781067b on Nov 8, 2018
  14. ken2812221 deleted the branch on Nov 8, 2018
  15. ryanofsky commented at 7:27 PM on November 8, 2018: member

    It's good to have this working, but I am still a little suspicious about this fix. If anyone with more knowledge about the build system wants to take another look at this, I think that would be useful.

  16. dzutto referenced this in commit f6c6dc6d03 on Aug 18, 2021
  17. dzutto referenced this in commit 5daf94ac91 on Aug 19, 2021
  18. dzutto referenced this in commit b4fbad77ed on Aug 19, 2021
  19. dzutto referenced this in commit 6fe1749ebd on Aug 23, 2021
  20. dzutto referenced this in commit e0337f6fc1 on Aug 26, 2021
  21. dzutto referenced this in commit d3272bdb77 on Aug 26, 2021
  22. dzutto referenced this in commit 2809b851cc on Aug 27, 2021
  23. PastaPastaPasta referenced this in commit b9df9815ba on Aug 29, 2021
  24. MarcoFalke locked this on Sep 8, 2021
Contributors
ken2812221DrahtBotryanofskyMarcoFalke
Labels
Build system

Milestone
0.18.0

Linked (view graph)
#14677 Build Windows wallet issue
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me