Doc: update release notes for changes since 0.17.0 branch #14688

pull harding wants to merge 2 commits into bitcoin:master from harding:2018-11-release-notes changing 7 files +137 −51
  1. harding commented at 2:23 PM on November 8, 2018: contributor

    This documents changes listed by git log v0.17.0...11e1ac3 --merges and integrates the existing detached release notes into the main file.

    My goal is to update the release notes each month in order to reduce the amount of writing and review that needs to be done all at once near the start of the RC cycle.

    Note: I've chosen to use fully-qualified URLs for linking to documentation, rather than shorter relative URLs that would otherwise be preferred, as the release notes are commonly copied into emails, reddit threads, and blog posts where relative URLs would be incomplete or would point to the wrong page.

  2. fanquake added the label Docs on Nov 8, 2018
  3. sipa deleted a comment on Nov 8, 2018
  4. DrahtBot commented at 5:10 PM on November 8, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14667 (Add deriveaddress RPC util method by Sjors)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. MarcoFalke approved
  6. MarcoFalke commented at 6:20 PM on November 8, 2018: member

    ACK b69f537596902c68aa4863ff98ed175dea3ff7df

  7. mruddy commented at 11:46 PM on November 9, 2018: contributor

    @harding #14060 added the config options: -zmqpubhashblockhwm -zmqpubhashtxhwm -zmqpubrawblockhwm -zmqpubrawtxhwm I wasn't aware of the detached release note convention so I didn't make one. Should I add one now, or is this note enough for you to make mention of the new options in the release notes?

  8. sipa commented at 3:45 AM on November 10, 2018: member

    I'm confused; these changes look like things that were in 0.17 already; they shouldn't go into master's release-notes (which will be for 0.18).

  9. laanwj commented at 10:40 AM on November 10, 2018: member

    Thanks for doing this!

    I'm confused; these changes look like things that were in 0.17 already; they shouldn't go into master's release-notes (which will be for 0.18).

    Are you sure? The command git log v0.17.0...11e1ac3 --merges does go down the master branch since the 0.17 fork. So apart from things that have been backported it should list PRs that are only on the master branch.

    edit: oh I was looking wrongly at first; getnodeaddresses, for example is not in 0.17.0, so I think this is correct

  10. laanwj commented at 10:46 AM on November 10, 2018: member

    I wasn't aware of the detached release note convention so I didn't make one. Should I add one now, or is this note enough for you to make mention of the new options in the release notes?

    If you want your feature to be documented in the release notes, preferably add one yourself, yes!

  11. harding commented at 3:34 PM on November 10, 2018: contributor

    @sipa it looks like you're correct, sorry about that. There was a large number of "backports" to 0.17 after the branch point but before the release so I didn't realize that they'd been backported. For example, 0f681cecadb9472b3d3ae2c1dd23d8173dc2e316 was the backport that put the descriptors.md file into 0.17, meaning it isn't actually new as this PR indicates.

    I'll check everything, make the edits, and comment here when I'm sure this PR only includes actual new changes.

  12. MarcoFalke commented at 3:46 PM on November 10, 2018: member

    The document has been backported, but it hasn't been mentioned in the release notes back then. Since it is not possible to change release notes after the release, we could not mention it at all, mention it on the 0.17.1 release, or on the master branch...?

  13. harding commented at 3:55 PM on November 10, 2018: contributor

    @MarcoFalke the document has been extended in recent commits that I think are unique to master, so I was thinking about just slightly revising my current description to say the document has been updated rather than saying it's new. I think that accomplishes the goal of informing users about it while also only describing new changes for 0.18.

  14. MarcoFalke commented at 3:59 PM on November 10, 2018: member

    Good point, but the descriptor fixups have also been backported to 0.17.1 in #14566

  15. harding commented at 4:03 PM on November 10, 2018: contributor

    @MarcoFalke I was thinking about the stuff in #14150 that I think is a new feature, and not particularly useful in 0.17, and so is IMO unlikely to be backported.

  16. Release notes: update notes through to 11e1ac3ae08 6062f0e613
  17. Release notes: integrate detached release notes ba8f0c6c8d
  18. harding force-pushed on Nov 11, 2018
  19. harding commented at 12:17 PM on November 11, 2018: contributor

    This is ready for review again. I've reviewed each line added in this PR to determine whether the relevant code change was backported to the 0.17 branch (as of its current tip, 5150accdd2a7c7f0edf964d56bd7d34b5f740cdc) and made the necessary changes---which only affected one item: I've relabeled the output script descriptors documentation as updated (not new) and moved its position in the list down below the notices about new documentation files.

    Note: this still only covers merges up to the commit mentioned in the OP; any subsequent notable merges will be documented in next month's update.

  20. fanquake commented at 12:41 PM on November 14, 2018: member

    utACK ba8f0c6

  21. laanwj merged this on Nov 14, 2018
  22. laanwj closed this on Nov 14, 2018

  23. laanwj referenced this in commit 99a3e6f0b1 on Nov 14, 2018
  24. laanwj referenced this in commit 2e8f9dc2bb on Nov 14, 2018
  25. laanwj referenced this in commit 031e3a32b2 on Jan 3, 2019
  26. deadalnix referenced this in commit 27ef44d03b on Jun 11, 2020
  27. PastaPastaPasta referenced this in commit 44f2da3495 on Jun 27, 2021
  28. PastaPastaPasta referenced this in commit f48ff35201 on Jun 28, 2021
  29. PastaPastaPasta referenced this in commit c54b296f4b on Jun 29, 2021
  30. Munkybooty referenced this in commit b80868dc6d on Jul 29, 2021
  31. Munkybooty referenced this in commit 3f6fac3226 on Aug 3, 2021
  32. Munkybooty referenced this in commit 2bcf95951f on Aug 5, 2021
  33. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-19 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me