test_node: get_mem_rss fixups #14693

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1811-qaTestNodeFixups changing 1 files +7 −10
  1. MarcoFalke commented at 10:20 PM on November 8, 2018: member

    Follow up to #14522:

    • Fix math (Memory usage increase relative to previous memory usage, not final memory usage)
    • remove shell=True
    • assert that the node is running
    • Make it work on BSD-like systems
  2. MarcoFalke added the label Tests on Nov 8, 2018
  3. MarcoFalke added the label Refactoring on Nov 8, 2018
  4. MarcoFalke force-pushed on Nov 8, 2018
  5. MarcoFalke force-pushed on Nov 8, 2018
  6. in test/functional/test_framework/test_node.py:133 in fa3c13b467 outdated
     138 | +        # Catching to avoid failing on platforms where ps
     139 | +        # isn't installed (SubprocessError) or doesn't work as expected (ValueError), e.g. BSD.
     140 |          #
     141 |          # We could later use something like `psutils` to work across platforms.
     142 | -        except Exception:
     143 | +        except (subprocess.SubprocessError, ValueError):
    


    jamesob commented at 10:48 PM on November 8, 2018:

    We could also try detecting/parsing the *BSD-style output, which looks like "RSS\n 123".

  7. jamesob approved
  8. jamesob commented at 10:49 PM on November 8, 2018: member

    ACK

    Thanks for the fixes!

  9. MarcoFalke force-pushed on Nov 8, 2018
  10. MarcoFalke force-pushed on Nov 8, 2018
  11. MarcoFalke force-pushed on Nov 8, 2018
  12. test_node: get_mem_rss fixups fa9ed38d57
  13. MarcoFalke force-pushed on Nov 8, 2018
  14. lucash-dev commented at 6:42 AM on November 9, 2018: contributor

    utACK

  15. practicalswift commented at 12:44 PM on November 11, 2018: contributor

    Concept ACK

  16. laanwj merged this on Nov 12, 2018
  17. laanwj closed this on Nov 12, 2018

  18. laanwj referenced this in commit af3c8a7e9f on Nov 12, 2018
  19. MarcoFalke deleted the branch on Nov 12, 2018
  20. random-zebra referenced this in commit bffe509aed on Jun 28, 2021
  21. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 00:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me