Building with clang (e.g. on FreeBSD) is very noisy due to -Wthread-safety-analysis warnings regarding boost. This change removes a number of unnecessary boost includes, and silences the rest of the warnings when building with clang. This allows more potentially interesting warnings to surface from the noise.
Tested on FreeBSD 11.2
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
@murrayn Can you post a few of the warnings? Could it be that you’re using an old version of Boost? :-)
ACK on removing the redundant headers
@murrayn Can you post a few of the warnings? Could it be that you’re using an old version of Boost? :-) @practicalswift I was originally using boost-libs-1.66.0_1, updated to boost-libs-1.68.0_3 with no improvement.
Here is the warning output from compiling one of the files:
https://0bin.net/paste/JAxYnpYsxSSxXz+4#-ObZEDfUOHpeAnguOYhkZMW5xL9Co7ea8E5E+evc9Zv
58@@ -59,8 +59,7 @@
59 #include <boost/algorithm/string/classification.hpp>
60 #include <boost/algorithm/string/replace.hpp>
61 #include <boost/algorithm/string/split.hpp>
62-#include <boost/bind.hpp>
63-#include <boost/thread.hpp>
64+
boost::bind and boost::thread*
boost/thread.h is included in scheduler.h
bitcoind size reduces by about 1%)
16@@ -17,8 +17,6 @@
17 #include <sys/stat.h>
18 #endif
19
20-#include <boost/thread.hpp>
21-
boost::this_thread::interruption_point()
7@@ -8,8 +8,6 @@
8 #include <util/system.h>
9 #include <validation.h>
10
11-#include <boost/thread.hpp>
12-
boost::this_thread::interruption_point()
boost/thread.hpp is already included by util/system.h
boost/thread/condition_variable in util/system.h. You can take a look at appveyor ci error message.
18@@ -19,8 +19,6 @@
19 #include <atomic>
20 #include <string>
21
22-#include <boost/thread.hpp>
9@@ -10,7 +10,6 @@
10 #include <util/time.h>
11
12 #include <atomic>
13-#include <boost/date_time/posix_time/posix_time.hpp>
14@@ -15,7 +15,6 @@
15 #include <set>
16 #include <stdlib.h>
17
18-#include <boost/bind.hpp>
9@@ -10,7 +10,6 @@
10 // boost::thread / boost::chrono should be ported to std::thread / std::chrono
11 // when we support C++11.
12 //
13-#include <boost/chrono/chrono.hpp>
7@@ -8,7 +8,6 @@
8 #include <reverselock.h>
9
10 #include <assert.h>
11-#include <boost/bind.hpp>
13@@ -14,7 +14,6 @@
14 #include <util/system.h>
15 #include <util/strencodings.h>
16
17-#include <boost/bind.hpp>
8@@ -9,9 +9,6 @@
9 #include <script/script.h>
10 #include <util/strencodings.h>
11
12-#include <boost/variant/apply_visitor.hpp>
13-#include <boost/variant/static_visitor.hpp>
14-
On master:
0test/lint/lint-includes.sh
1Good job! The Boost dependency "boost/filesystem/fstream.hpp" is no longer used.
2Please remove it from EXPECTED_BOOST_INCLUDES in test/lint/lint-includes.sh
3to make sure this dependency is not accidentally reintroduced.
I’ll make a PR.
11@@ -12,7 +12,6 @@
12 #endif
13
14 #include <boost/filesystem.hpp>
15-#include <boost/filesystem/fstream.hpp>
