Remove redundant readme info in /doc #14755

pull merland wants to merge 1 commits into bitcoin:master from merland:issue-14639 changing 2 files +2 −40
  1. merland commented at 1:49 PM on November 19, 2018: contributor

    As outlined in #14639, there is some old and redundant info in two READMEs in /doc. This PR fixes that. Also, changed a download link to point to the download page (instead of the releases page).

  2. Removed redundant README info and changed download pointer from /releases to /download 7a03ba2d4f
  3. fanquake added the label Docs on Nov 19, 2018
  4. DrahtBot commented at 2:37 PM on November 19, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14167 ([WIP] docs: improve linux tar packages by cisba)
    • #14026 (docs: updated README.md to include link to repo, files list and description by cisba)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  5. MarcoFalke added the label Needs gitian build on Nov 19, 2018
  6. DrahtBot commented at 1:32 AM on November 20, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 6d58a5c3b05585b01c960776e00856637ff1794d (master):

    Gitian builds for commit 34a840b1c54866d201746396095905d43abe839d (master and this pull):

  7. DrahtBot removed the label Needs gitian build on Nov 20, 2018
  8. MarcoFalke closed this on Nov 20, 2018
  9. merland commented at 9:44 PM on November 20, 2018: contributor

    @MarcoFalke Reason for closing?

  10. MarcoFalke commented at 9:47 PM on November 20, 2018: member

    The file is required and not redundant (see the build failures of gitian and travis)

  11. merland commented at 10:08 PM on November 20, 2018: contributor

    I suspected that, but I don't get the underlying reason, why a .txt file with unintuitive contents is mandatory. It's confusing for the reader. If impossible to remove, can we keep the file but have only a link in it?

    On Tue, 20 Nov 2018, 22:48 MarcoFalke <notifications@github.com wrote:

    The file is required and not redundant (see the build failures of gitian and travis)

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/14755#issuecomment-440440902, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbp5Gfk9egWcYdkoI_7lzdbNWmYQBLjks5uxHjBgaJpZM4YpJGy .

  12. MarcoFalke commented at 10:13 PM on November 20, 2018: member

    Link to what? See the linked conflicting pull requests for how this is being used.

  13. merland commented at 10:17 PM on November 20, 2018: contributor

    Link to the official documentation for running a node, to avoid duplication and confusion.
    However, I guess I'm missing something here. Will read up on gitian builds and the related PRs. Thanks for now.

  14. MarcoFalke commented at 10:20 PM on November 20, 2018: member

    Oh that makes sense I guess. Include the essential information in the distributed (offline) file and link to an online resource for further information.

  15. merland commented at 9:40 AM on November 21, 2018: contributor

    I updated the commit according to the discussion above. Hopefully ok for gitian build.
    Would you consider re-opening the PR?

    ping @MarcoFalke

  16. MarcoFalke commented at 6:56 PM on November 22, 2018: member

    GitHub won't allow to reopen a pull request after the linked branch has been force pushed. Feel free to create a fresh pull request.

  17. merland commented at 7:25 PM on November 22, 2018: contributor

    Alright, thanks.

  18. MarcoFalke locked this on Sep 8, 2021
Contributors
merlandDrahtBotMarcoFalke
Labels
Docs
Linked (view graph)
#14639 Misplaced instructions in READMEs?#14787 Remove misplaced intro text in /doc + minor fixes
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me