The code which soft disabled address discovery/upnp when not listening was instead disabling it when listening.
Fix inverted logic for !Discover/!UPNP when !Listen. #1477
pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:master changing 1 files +1 −1-
gmaxwell commented at 4:16 PM on June 17, 2012: contributor
-
Fix inverted logic for !Discover/!UPNP when !Listen. 3bbb49de55
-
Diapolo commented at 4:24 PM on June 17, 2012: none
ACK and verified to work!
-
Diapolo commented at 7:43 PM on June 17, 2012: none
Additional info, this patch fixes a serious issue with the testnet3, where all nodes currently get the same NICK on IRC and so the address exchange via IRC does not work / is faulty.
-
gmaxwell commented at 7:46 PM on June 17, 2012: contributor
Not so, nodes which aren't listening get other nicks just fine! (to be clear, I'm being sarcastic— advertising only the nodes which aren't listening isn't helpful)
-
sipa commented at 12:06 AM on June 18, 2012: member
ACK
- sipa referenced this in commit 432d28d3bb on Jun 18, 2012
- sipa merged this on Jun 18, 2012
- sipa closed this on Jun 18, 2012
- coblee referenced this in commit 9965961191 on Jul 17, 2012
- suprnurd referenced this in commit 2daea77a5b on Dec 5, 2017
- lateminer referenced this in commit 6879786153 on May 6, 2020
- lateminer referenced this in commit 69cdcdcc68 on May 6, 2020
- lateminer referenced this in commit 66f523d46f on May 6, 2020
- DrahtBot locked this on Sep 8, 2021
