refactor: Convert comments to thread safety annotations #14772

1. 
   MarcoFalke commented at 12:40 AM on November 21, 2018: member

   Convert human-only-readable annotations to human-and-machine-readable annotations.

2. MarcoFalke added the label Refactoring on Nov 21, 2018
3. Convert comments to thread safety annotations fa71eb5196
4. MarcoFalke force-pushed on Nov 21, 2018
5. 
   DrahtBot commented at 1:41 AM on November 21, 2018: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #13123 (net: Add Clang thread safety annotations for guarded variables in the networking code by practicalswift)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. 
   practicalswift commented at 8:01 AM on November 21, 2018: contributor

   ACK regarding the changes, but this PR is a subset of the PR #13123 submitted back in April (with the exception of the change to src/validation.cpp)? :-)

   Close this PR in favour of #13123?

7. 
   promag commented at 11:04 AM on November 22, 2018: member

   utACK fa71eb5.

   Convert human-only-readable annotations to human-and-machine-readable annotations. @practicalswift like Marco said, these are the obvious annotations. IMO your pull will be simplified after this.

8. 
   practicalswift commented at 11:01 PM on November 22, 2018: contributor

   utACK fa71eb5196fc157213d7b6364071530ab19df724 @promag Makes sense, but where did Marco say that? I missed it :-)

9. 
   promag commented at 4:13 PM on November 23, 2018: member

   @practicalswift updated my comment 😛

10. MarcoFalke added this to the milestone 0.18.0 on Nov 26, 2018
11. MarcoFalke merged this on Nov 27, 2018
12. MarcoFalke closed this on Nov 27, 2018

    ---

13. MarcoFalke referenced this in commit d491030076 on Nov 27, 2018
14. MarcoFalke deleted the branch on Nov 27, 2018
15. UdjinM6 referenced this in commit c164e500c2 on Sep 1, 2021
16. UdjinM6 referenced this in commit 8c64eec579 on Sep 2, 2021
17. DrahtBot locked this on Sep 8, 2021

Milestone
0.18.0