Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions #14818

1. 
   luke-jr commented at 5:47 PM on November 27, 2018: member

   When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise. Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used. The error code is still checked to ensure it is of the correct kind of failure.

2. Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions

   When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise.
   Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used.
   The error code is still checked to ensure it is of the correct kind of failure.

   097c4aa379
3. Bugfix: test/functional/rpc_psbt: Correct test description comment c87fc71f7e
4. MarcoFalke requested review from instagibbs on Nov 27, 2018
5. 
   MarcoFalke commented at 6:53 PM on November 27, 2018: member

   Fixes: #13738

6. 
   instagibbs commented at 6:56 PM on November 27, 2018: member

   didn't know you could give an empty string

   utACK https://github.com/bitcoin/bitcoin/pull/14818/commits/c87fc71f7e9316bcc0653cd86c50177424b5b1f9

7. 
   luke-jr commented at 6:56 PM on November 27, 2018: member

   I'm not sure it fixes #13738. Isn't that a "no exception thrown" issue? The bug fixed here is that it's throwing a different exception...

8. 
   MarcoFalke commented at 7:01 PM on November 27, 2018: member

   @luke-jr Right

9. 
   achow101 commented at 10:22 PM on November 27, 2018: member

   utACK c87fc71f7e9316bcc0653cd86c50177424b5b1f9

10. MarcoFalke added the label Tests on Nov 27, 2018
11. MarcoFalke referenced this in commit 8cca1fbea9 on Apr 25, 2019
12. MarcoFalke merged this on Apr 25, 2019
13. MarcoFalke closed this on Apr 25, 2019

    ---

14. sidhujag referenced this in commit eb6d7421ed on Apr 27, 2019
15. MarcoFalke referenced this in commit 966d8d0842 on Jun 18, 2019
16. MarcoFalke referenced this in commit 832eb4ff54 on Jun 18, 2019
17. HashUnlimited referenced this in commit dde28d0fad on Aug 23, 2019
18. HashUnlimited referenced this in commit a4591377e5 on Aug 23, 2019
19. Bushstar referenced this in commit 1c0c1012cf on Aug 24, 2019
20. Bushstar referenced this in commit 54789e199e on Aug 24, 2019
21. deadalnix referenced this in commit 4957ae63d6 on Jun 21, 2020
22. pravblockc referenced this in commit 9a23fe0916 on Sep 25, 2021
23. DrahtBot locked this on Dec 16, 2021

Review Requested
instagibbs