depends: qt 5.9.7 #14849

pull fanquake wants to merge 3 commits into bitcoin:master from fanquake:qt-5-9-7 changing 3 files +22 −10
  1. fanquake commented at 2:08 PM on November 30, 2018: member

    This PR upgrades expat and qt in depends. The intention is to upgrade Qt in master to the latest point release of the current Qt LTS. This change can then be back-ported to the 0.17 branch (wether it makes it into 0.17.1 or not).

    Then, sometime before the 0.18.0 release, we could move to using Qt 5.12+ in depends (which is also LTS). That discussion, as well as minimum supported Qt versions is in #13478.

    Qt 5.9.7

    Release announcement Changelog

    Expat 2.2.6

    • Avoid doing arithmetic with NULL pointers in XML_GetBuffer
    • Fix 2.2.5 regression with suspend-resume while parsing a document like <root/>

    Full changelog here

    https://github.com/bitcoin/bitcoin/pull/14849/commits/a46c8476e9598742e52944b6270b1854c8f500a2 disables a bunch of qt features we aren't currently using. This speeds up the qt depends build slightly (also decreases the size of the built qt-5.9.7 tar by about 2%). The disabling is somewhat unintuitive, hence [wip] until after a travis run and gitian build.

  2. fanquake added the label Build system on Nov 30, 2018
  3. fanquake added the label Needs gitian build on Nov 30, 2018
  4. hebasto commented at 7:05 PM on November 30, 2018: member

    I've look through ./configure --help and not sure if these options: -no-egl -no-libudev -no-openvg -optimized-qmake are acceptable by Qt 5.9.7 configure.

  5. in depends/packages/qt.mk:80 in 81f33098b3 outdated 
      75 | +$(package)_config_opts += -no-feature-lcdnumber
  76 | +$(package)_config_opts += -no-feature-pdf
  77 |  $(package)_config_opts += -no-feature-printer
  78 |  $(package)_config_opts += -no-feature-printdialog
  79 |  $(package)_config_opts += -no-feature-concurrent
  80 | +$(package)_config_opts += -no-feature-sql
    hebasto commented at 7:53 PM on November 30, 2018:

    ./configure --list-features output does not list sql feature.

    fanquake commented at 11:50 PM on November 30, 2018:

    Passing -no-feature-sql disables the Qt sql module in its entirety, see the output in the configure summary:

    Qt modules and options:
  Qt Network ............................. yes
  Qt Sql ................................. no
  Qt Testlib ............................. yes
  6. hebasto changes_requested
  7. hebasto commented at 8:38 PM on November 30, 2018: member

    Some thoughts about disabled Qt features.

    1. Qt build does not include QtPrintSupport module; therefore, it is redundant to mention:
    $(package)_config_opts += -no-feature-printer
$(package)_config_opts += -no-feature-printdialog
    1. Qt build does not include QtConcurrent module; therefore, it is redundant to mention:
    $(package)_config_opts += -no-feature-concurrent
    1. Also these features can be disabled:
    $(package)_config_opts += -no-feature-udpsocket
$(package)_config_opts += -no-feature-syntaxhighlighter
  8. DrahtBot commented at 8:50 PM on November 30, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14066 (gitian-linux: Build binaries for 64-bit POWER by luke-jr)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  9. fanquake force-pushed on Nov 30, 2018
  10. fanquake commented at 11:52 PM on November 30, 2018: member

    @hebasto Thanks for your thoughts:

    $(package)_config_opts += -no-feature-printer $(package)_config_opts += -no-feature-printdialog

    These were specifically introduced to fix the depends build on macOS. I'd rather leave them in place for now. Similar thoughts for -no-egl -no-libudev -no-openvg -optimized-qmake. Maybe once we move to Qt 6 we can review the configure flags we are using. However for now I'd rather only remove extra unused features/reduce compile times etc, than inadvertently break any depends/gitian builds by removing a potential unused flag.

    $(package)_config_opts += -no-feature-concurrent

    We can leave this module disabled, and not do any extra compilation/work during the Qt compile. i.e

    Qt modules and options:
  Qt Concurrent .......................... no

    $(package)_config_opts += -no-feature-udpsocket $(package)_config_opts += -no-feature-syntaxhighlighter

    I've added these + -no-feature-statemachine to the PR.

  11. hebasto commented at 9:43 AM on December 1, 2018: member

    @fanquake You are right. Qt docs confused me a little :) utACK 311498de728bd584d51865aa62e06091235baab5

  12. DrahtBot commented at 4:04 PM on December 1, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 60b20c869f8df9a81b5080ebcbe8c9cf4e6b9d77 (master):

    Gitian builds for commit 74fb02cb057ddb5016843662f3206e41049e4cc7 (master and this pull):

  13. DrahtBot removed the label Needs gitian build on Dec 1, 2018
  14. jonasschnelli commented at 12:40 AM on December 10, 2018: contributor

    Successful gitian build: https://bitcoin.jonasschnelli.ch/build/907

    Tested on OSX: <img width="1322" alt="bildschirmfoto 2018-12-09 um 13 55 17" src="https://user-images.githubusercontent.com/178464/49704722-9eb5bf00-fbba-11e8-97b1-a28e8ff671f3.png">

  15. DrahtBot added the label Needs rebase on Dec 12, 2018
  16. DrahtBot commented at 12:55 PM on December 12, 2018: member

    <!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase

  17. depends: expat 2.2.6 095e765975
  18. depends: qt 5.9.7 73b46eeb7e
  19. depends: disable unused qt features a46c8476e9
  20. fanquake force-pushed on Dec 12, 2018
  21. fanquake renamed this:
    [wip] depends: qt 5.9.7
    depends: qt 5.9.7
    on Dec 12, 2018
  22. fanquake removed the label Needs rebase on Dec 12, 2018
  23. fanquake commented at 1:00 PM on December 12, 2018: member

    Rebased on master and removed [wip].

  24. MarcoFalke added the label Needs gitian build on Dec 12, 2018
  25. laanwj commented at 1:34 PM on December 13, 2018: member

    utACK a46c8476e9598742e52944b6270b1854c8f500a2

  26. laanwj merged this on Dec 13, 2018
  27. laanwj closed this on Dec 13, 2018
  28. laanwj referenced this in commit 62c15471f1 on Dec 13, 2018
  29. fanquake referenced this in commit feac85bd5f on Dec 13, 2018
  30. fanquake referenced this in commit f68dfe3a6d on Dec 13, 2018
  31. fanquake referenced this in commit ea16f7b9cb on Dec 13, 2018
  32. fanquake referenced this in commit c295681579 on Dec 13, 2018
  33. fanquake referenced this in commit 70b33c2577 on Dec 13, 2018
  34. DrahtBot commented at 5:25 PM on December 13, 2018: member

    <!--a722867cd34abeea1fadc8d60700f111-->

    Gitian builds for commit 5f23460c7e316fe7c944680f3feff07ebb867f70 (master):

    Gitian builds for commit 39019f7d1a424e14fbb4ed2bf05412eb3f8b958f (master and this pull):

  35. DrahtBot removed the label Needs gitian build on Dec 13, 2018
  36. fanquake deleted the branch on Jan 28, 2019
  37. deadalnix referenced this in commit 68e6fd9160 on Mar 31, 2020
  38. Munkybooty referenced this in commit e5ce8bad44 on Aug 8, 2021
  39. Munkybooty referenced this in commit 67690c21c9 on Aug 11, 2021
  40. Munkybooty referenced this in commit 3e3809517d on Aug 11, 2021
  41. Munkybooty referenced this in commit b1688e6fc7 on Aug 13, 2021
  42. ftrader referenced this in commit ca284daf00 on Aug 13, 2021
  43. Munkybooty referenced this in commit f8aa222ba3 on Aug 15, 2021
  44. DrahtBot locked this on Dec 16, 2021
Contributors
fanquakehebastoDrahtBotjonasschnellilaanwj
Labels
Build system
Linked (view graph)
#13478 [RFC] gui: Minimum required Qt5#14949 [0.17] Backport #14849 Qt 5.9.7
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me