depends: latest RapidCheck #14853

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:latest-rapidcheck changing 2 files +11 −12
  1. fanquake commented at 4:17 am on December 1, 2018: member

    This updates RapidCheck to the latest version available from https://github.com/emil-e/rapidcheck.

    RapidCheck now uses the new RC_INSTALL_ALL_EXTRAS option, to install the extra boost_test packages, which should unblock progress in #14430.

  2. fanquake added the label Build system on Dec 1, 2018
  3. fanquake added the label Tests on Dec 1, 2018
  4. fanquake requested review from Christewart on Dec 1, 2018
  5. fanquake renamed this:
    depends: latest rapidcheck, enable property based tests on Travis
    [wip] depends: latest rapidcheck, enable property based tests on Travis
    on Dec 1, 2018
  6. fanquake force-pushed on Dec 1, 2018
  7. fanquake force-pushed on Dec 1, 2018
  8. fanquake added the label Needs gitian build on Dec 1, 2018
  9. fanquake force-pushed on Dec 1, 2018
  10. fanquake commented at 5:44 am on December 1, 2018: member

    Apologies for the push spam. Looks like rapidcheck testing on Travis is still failing with the same memory access violation error as #14171. I’ll leave the build log up for now if anyone else wants to investigate, otherwise, the second commit here could be dropped.

     0Running tests: versionbits_tests from test/versionbits_tests.cpp
     1Running tests: key_properties from test/key_properties.cpp
     2Running 4 test cases...
     3Test cases order is shuffled using seed: 1462083212
     4Entering test module "Bitcoin Test Suite"
     5test/key_properties.cpp(22): Entering test suite "key_properties"
     6test/key_properties.cpp(38): Entering test case "key_set_symmetry"
     7Using configuration: seed=1143137297392740439
     8unknown location(0): fatal error: in "key_properties/key_set_symmetry": memory access violation at address: 0x00000020: no mapping at fault address
     9test/key_properties.cpp(38): last checkpoint: "key_set_symmetry" entry.
    10Test is aborted
    11test/key_properties.cpp(38): Leaving test case "key_set_symmetry"; testing time: 19607us
    12Test is aborted
    13test/key_properties.cpp(22): Leaving test suite "key_properties"; testing time: 19671us
    14Test is aborted
    15Leaving test module "Bitcoin Test Suite"; testing time: 19889us
    
  11. fanquake commented at 9:16 am on December 1, 2018: member

    Managed to get a backtrace in what should have been an equivalent environment. cc @Christewart

     0Thread 1 (Thread 0x7ffff7fe5780 (LWP 72946)):
     1[#0](/bitcoin-bitcoin/0/)  0x00005555561fe58f in rc::Shrinkable<rc::detail::Any>::value() const ()
     2[#1](/bitcoin-bitcoin/1/)  0x000055555623abe6 in rc::gen::detail::ExecHandler::onGenerate(rc::Gen<rc::detail::Any> const&) ()
     3[#2](/bitcoin-bitcoin/2/)  0x00005555559b418e in rc::Gen<std::tuple<CKey, CKey> >::operator*() const ()
     4[#3](/bitcoin-bitcoin/3/)  0x00005555559b45a5 in std::pair<rc::detail::FunctionTraitsImpl<std::decay<rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)> >::type>::ReturnType, rc::gen::detail::Recipe> rc::gen::detail::execWithRecipe<rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)> >(rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)>, rc::gen::detail::Recipe) ()
     5[#4](/bitcoin-bitcoin/4/)  0x00005555559b4a03 in rc::Shrinkable<std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe> >::ShrinkableImpl<rc::shrinkable::detail::JustShrinkShrinkable<rc::Shrinkable<std::pair<rc::detail::FunctionTraitsImpl<std::decay<rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)> >::type>::ReturnType, rc::gen::detail::Recipe> > rc::gen::detail::shrinkableWithRecipe<rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)> >(rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)>, rc::gen::detail::Recipe)::{lambda()#1}, rc::Shrinkable<std::pair<rc::detail::FunctionTraitsImpl<std::decay<rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)> >::type>::ReturnType, rc::gen::detail::Recipe> > rc::gen::detail::shrinkableWithRecipe<rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)> >(rc::detail::PropertyAdapter<void (*)(CKey const&, CKey const&), void (CKey const&, CKey const&)>, rc::gen::detail::Recipe)::{lambda(std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe>&&)#2}> >::value() const ()
     6[#5](/bitcoin-bitcoin/5/)  0x0000555556203b21 in rc::Shrinkable<std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe> >::value() const ()
     7[#6](/bitcoin-bitcoin/6/)  0x00005555561fdad3 in rc::shrinkable::detail::MapShrinkable<std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe>, rc::detail::mapToCaseDescription(rc::Gen<std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe> >)::{lambda(std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe>&&)#1}>::value() const ()
     8[#7](/bitcoin-bitcoin/7/)  0x00005555561fd982 in rc::Shrinkable<rc::detail::CaseDescription>::ShrinkableImpl<rc::shrinkable::detail::MapShrinkable<std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe>, rc::detail::mapToCaseDescription(rc::Gen<std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe> >)::{lambda(std::pair<rc::detail::TaggedResult, rc::gen::detail::Recipe>&&)#1}> >::value() const ()
     9[#8](/bitcoin-bitcoin/8/)  0x000055555621055b in rc::Shrinkable<rc::detail::CaseDescription>::value() const ()
    10[#9](/bitcoin-bitcoin/9/)  0x000055555620f036 in rc::detail::searchProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestParams const&, rc::detail::TestListener&) ()
    11[#10](/bitcoin-bitcoin/10/) 0x000055555620f66b in rc::detail::(anonymous namespace)::doTestProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestParams const&, rc::detail::TestListener&) ()
    12[#11](/bitcoin-bitcoin/11/) 0x000055555620fb8c in rc::detail::testProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestMetadata const&, rc::detail::TestParams const&, rc::detail::TestListener&) ()
    13[#12](/bitcoin-bitcoin/12/) 0x00005555561ec0ce in rc::detail::checkProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestMetadata const&, rc::detail::TestParams const&, rc::detail::TestListener&, std::unordered_map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, rc::detail::Reproduce, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, rc::detail::Reproduce> > > const&) ()
    14[#13](/bitcoin-bitcoin/13/) 0x00005555561ec2be in rc::detail::checkProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestMetadata const&, rc::detail::TestParams const&, rc::detail::TestListener&) ()
    15[#14](/bitcoin-bitcoin/14/) 0x00005555561ec322 in rc::detail::checkProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestMetadata const&, rc::detail::TestParams const&) ()
    16[#15](/bitcoin-bitcoin/15/) 0x00005555561ec37b in rc::detail::checkProperty(rc::Gen<rc::detail::CaseDescription> const&, rc::detail::TestMetadata const&) ()
    17[#16](/bitcoin-bitcoin/16/) 0x00005555559af306 in void rc::detail::checkBoostTest<void (*)(CKey const&, CKey const&)>(void (*&&)(CKey const&, CKey const&)) ()
    18[#17](/bitcoin-bitcoin/17/) 0x00005555559a7763 in key_properties::key_uniqueness_invoker() ()
    19[#18](/bitcoin-bitcoin/18/) 0x000055555601a5d1 in boost::function0<void>::operator() (this=0x555556a41058) at ./boost/function/function_template.hpp:759
    20[#19](/bitcoin-bitcoin/19/) 0x0000555556019cb1 in boost::detail::forward::operator() (this=0x7fffffffd1b8) at ./boost/test/impl/execution_monitor.ipp:1300
    21[#20](/bitcoin-bitcoin/20/) 0x000055555601a9dc in boost::detail::function::function_obj_invoker0<boost::detail::forward, int>::invoke (function_obj_ptr=...)
    22    at ./boost/function/function_template.hpp:138
    23[#21](/bitcoin-bitcoin/21/) 0x000055555601a7b9 in boost::function0<int>::operator() (this=0x7fffffffd1b0) at ./boost/function/function_template.hpp:760
    24[#22](/bitcoin-bitcoin/22/) 0x0000555556019f61 in boost::detail::do_invoke<boost::shared_ptr<boost::detail::translator_holder_base>, boost::function<int ()> >(boost::shared_ptr<boost::detail::translator_holder_base> const&, boost::function<int ()> const&) (tr=..., F=...) at ./boost/test/impl/execution_monitor.ipp:281
    25[#23](/bitcoin-bitcoin/23/) 0x00005555560188b2 in boost::execution_monitor::catch_signals(boost::function<int ()> const&) (
    26    this=0x5555569ee100 <boost::unit_test::singleton<boost::unit_test::unit_test_monitor_t>::instance()::the_inst>, F=...)
    27    at ./boost/test/impl/execution_monitor.ipp:864
    28[#24](/bitcoin-bitcoin/24/) 0x0000555556018a36 in boost::execution_monitor::execute(boost::function<int ()> const&) (
    29    this=0x5555569ee100 <boost::unit_test::singleton<boost::unit_test::unit_test_monitor_t>::instance()::the_inst>, F=...)
    30    at ./boost/test/impl/execution_monitor.ipp:1203
    31[#25](/bitcoin-bitcoin/25/) 0x00005555560196b0 in boost::execution_monitor::vexecute(boost::function<void ()> const&) (
    32    this=0x5555569ee100 <boost::unit_test::singleton<boost::unit_test::unit_test_monitor_t>::instance()::the_inst>, F=...)
    33    at ./boost/test/impl/execution_monitor.ipp:1309
    34[#26](/bitcoin-bitcoin/26/) 0x0000555555fb5d84 in boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::function<void ()> const&, unsigned int) (
    35    this=0x5555569ee100 <boost::unit_test::singleton<boost::unit_test::unit_test_monitor_t>::instance()::the_inst>, func=..., timeout=0)
    36    at ./boost/test/impl/unit_test_monitor.ipp:46
    37[#27](/bitcoin-bitcoin/27/) 0x0000555555f6c445 in boost::unit_test::framework::state::execute_test_tree (
    38    this=0x5555569edf20 <boost::unit_test::framework::impl::(anonymous namespace)::s_frk_state()::the_inst>, tu_id=65838, timeout=0, 
    39    p_random_generator=0x0) at ./boost/test/impl/framework.ipp:717
    40[#28](/bitcoin-bitcoin/28/) 0x0000555555f6bdb1 in boost::unit_test::framework::state::execute_test_tree (
    41    this=0x5555569edf20 <boost::unit_test::framework::impl::(anonymous namespace)::s_frk_state()::the_inst>, tu_id=68, timeout=0, 
    42    p_random_generator=0x0) at ./boost/test/impl/framework.ipp:666
    43[#29](/bitcoin-bitcoin/29/) 0x0000555555f6bdb1 in boost::unit_test::framework::state::execute_test_tree (
    44    this=0x5555569edf20 <boost::unit_test::framework::impl::(anonymous namespace)::s_frk_state()::the_inst>, tu_id=1, timeout=0, p_random_generator=0x0)
    45    at ./boost/test/impl/framework.ipp:666
    46[#30](/bitcoin-bitcoin/30/) 0x0000555555f650ce in boost::unit_test::framework::run (id=1, continue_test=true) at ./boost/test/impl/framework.ipp:1442
    47[#31](/bitcoin-bitcoin/31/) 0x0000555555fb2287 in boost::unit_test::unit_test_main (init_func=0x55555567bbd0 <init_unit_test_suite(int, char**)>, argc=3, argv=0x7fffffffe708)
    48    at ./boost/test/impl/unit_test_main.ipp:231
    49[#32](/bitcoin-bitcoin/32/) 0x0000555555fb2588 in main (argc=3, argv=0x7fffffffe708) at ./boost/test/impl/unit_test_main.ipp:286
    
  12. DrahtBot removed the label Needs gitian build on Dec 5, 2018
  13. depends: latest rapidcheck, use INSTALL_ALL_EXTRAS ac67582ff7
  14. fanquake force-pushed on Mar 24, 2019
  15. fanquake renamed this:
    [wip] depends: latest rapidcheck, enable property based tests on Travis
    depends: latest RapidCheck
    on Mar 24, 2019
  16. fanquake deleted a comment on Mar 24, 2019
  17. fanquake added the label Needs gitian build on Mar 24, 2019
  18. DrahtBot commented at 8:57 pm on March 24, 2019: member

    Gitian builds for commit 7b13c646457980f44599412f243694fa682a1abf (master):

    Gitian builds for commit b7c9b7cb20b8c748e14e6c3f9b6d90ce4b05b857 (master and this pull):

  19. DrahtBot removed the label Needs gitian build on Mar 24, 2019
  20. fanquake removed review request from Christewart on Mar 25, 2019
  21. fanquake requested review from Christewart on Mar 25, 2019
  22. in depends/packages/rapidcheck.mk:3 in ac67582ff7
    0@@ -1,18 +1,17 @@
    1 package=rapidcheck
    2-$(package)_version=10fc0cb
    3-$(package)_download_path=https://github.com/MarcoFalke/rapidcheck/archive
    4-$(package)_file_name=$(package)-$($(package)_version).tar.gz
    5-$(package)_sha256_hash=9640926223c00af45bce4c7df8b756b5458a89b2ba74cfe3e404467f13ce26df
    6+$(package)_version=3eb9b4ff69f4ff2d9932e8f852c2b2a61d7c20d3
    7+$(package)_download_path=https://github.com/emil-e/rapidcheck/archive
    


    Christewart commented at 10:51 am on March 25, 2019:
    Is there a reason we don’t use the bitcoin core fork? https://github.com/bitcoin-core/rapidcheck

    fanquake commented at 10:58 am on March 25, 2019:
    We haven’t actually made any changes yet, so I think sticking with upstream is best for now.
  23. MarcoFalke commented at 1:30 pm on March 25, 2019: member
    utACK ac67582ff7ab5f2b75bbc961e8274bf62970e7ab
  24. Christewart commented at 12:17 pm on April 2, 2019: member
    utack ac67582ff7ab5f2b75bbc961e8274bf62970e7ab
  25. MarcoFalke merged this on Apr 2, 2019
  26. MarcoFalke closed this on Apr 2, 2019

  27. MarcoFalke referenced this in commit 2c364fde42 on Apr 2, 2019
  28. fanquake deleted the branch on Jan 22, 2020
  29. deadalnix referenced this in commit 33d30ef033 on Feb 27, 2020
  30. ftrader referenced this in commit 971ca32b9d on May 19, 2020
  31. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-19 00:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me