Ooff, we missed some backports that were tagged.
Checked:
- In 7a590d8 (clean cherry-pick): The test changes fail without the code changes
0.17: Further backports #14878
pull MarcoFalke wants to merge 1 commits into bitcoin:0.17 from MarcoFalke:Mf1812-17Backports changing 2 files +4 −1-
MarcoFalke commented at 10:42 PM on December 5, 2018: member
-
7a590d8390
fix converttopsbt permitsigdata arg, add basic test
Github-Pull: #14356 Rebased-From: 88a79cb436b30b39d37d139da723f5a31e9d161b
- MarcoFalke added the label Backport on Dec 5, 2018
- MarcoFalke added this to the milestone 0.17.1 on Dec 5, 2018
-
gmaxwell commented at 10:44 PM on December 5, 2018: contributor
utACK
- MarcoFalke force-pushed on Dec 5, 2018
-
MarcoFalke commented at 10:54 PM on December 5, 2018: member
There are still some more tagged, if someone else wants to take care of them (ideally the pull request author or a reviewer): https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport%22+is%3Aclosed
-
meshcollider commented at 11:32 AM on December 6, 2018: contributor
-
laanwj commented at 2:13 PM on December 6, 2018: member
utACK
There are still some more tagged, if someone else wants to take care of them (ideally the pull request author or a reviewer): https://github.com/bitcoin/bitcoin/issues?q=label%3A%22Needs+backport%22+is%3Aclosed
Would it make sense to postpone some of the backports to 0.17.2? It seems like new things to backport to 0.17 are added all the time, which is okay, but at some point we'd want to cut a release.
- laanwj merged this on Dec 6, 2018
- laanwj closed this on Dec 6, 2018
- laanwj referenced this in commit 8b8b3a9a5f on Dec 6, 2018
- MarcoFalke deleted the branch on Dec 6, 2018
- MarcoFalke locked this on Sep 8, 2021
