[doc] developer-notes.md: point out that UniValue deviates from upstream #14882

pull Sjors wants to merge 1 commits into bitcoin:master from Sjors:2018/12/doc-univalue changing 1 files +1 −1

Sjors commented at 11:06 AM on December 6, 2018: member
While debugging an issue I was somewhat surprised to learn that we've moved src/univalue from https://github.com/jgarzik/univalue to https://github.com/bitcoin-core/univalue, that these repos are both maintained and they're different.

The first mention of using the bitcoin-core repo is from late 2015 in #7157. I didn't check when the last common ancestor commit is.

I couldn't find documentation as to why (these things just happen in open source of course), but at minimum we should make this more clear.

There's also the following line in config.ac that I'm not sure what to do with:
```
AC_INIT([univalue], [1.0.3],
        [http://github.com/jgarzik/univalue/])
```
[doc] developer-notes.md: point out that UniValue deviates from upstream a67d71311d
Sjors commented at 11:08 AM on December 6, 2018: member

cc @luke-jr, @MarcoFalke, @jnewbery
fanquake added the label Docs on Dec 6, 2018
laanwj commented at 2:42 PM on December 6, 2018: member

Upstream univalue wasn't (or hardly) maintained for a long time so we've at some point started maintaining it ourselves.

Updating the various URLs makes sense.
practicalswift commented at 3:00 PM on December 6, 2018: contributor

utACK a67d71311d59fb06c9d51369722c9656e497a729
jnewbery commented at 3:38 PM on December 6, 2018: member

ACK a67d71311d59fb06c9d51369722c9656e497a729. Documentation should reflect reality.

Reviewers: please also consider reviewing a clarification to the README for our univalue fork: https://github.com/bitcoin-core/univalue/pull/17
MarcoFalke merged this on Dec 6, 2018
MarcoFalke closed this on Dec 6, 2018
MarcoFalke referenced this in commit 4987cdd16d on Dec 6, 2018
karelbilek commented at 4:49 PM on December 6, 2018: contributor

The autoconf thing is still different, right?
Sjors deleted the branch on Dec 6, 2018
Sjors commented at 7:39 PM on December 6, 2018: member

@karel-3d I didn't touch that, as I have no idea what that line is doing.
luke-jr commented at 2:50 AM on December 20, 2018: member

Upstream univalue is still maintained. I'm not sure why @laanwj is claiming otherwise.

That we have a fork of it at all, is a bug.
Sjors commented at 11:22 AM on December 20, 2018: member

@luke-jr it might be worth a separate Github issue to discuss if we want to migrate back to upstream.
laanwj commented at 1:36 PM on December 20, 2018: member

Upstream univalue is still maintained. I'm not sure why @laanwj is claiming otherwise.

It has very spottily maintained for a long time, and at the time we needed some fixes in. I haven't checked the status for a long time so it may be different now. I'm not "claiming otherwise" I think I was very precise in my wording.
luke-jr commented at 5:46 PM on December 20, 2018: member

@Sjors I opened #15009
PastaPastaPasta referenced this in commit d45118cda9 on Jun 27, 2021
PastaPastaPasta referenced this in commit c004d97ec3 on Jun 28, 2021
PastaPastaPasta referenced this in commit 94c21bf890 on Jun 29, 2021
PastaPastaPasta referenced this in commit 0aafa74228 on Jul 1, 2021
PastaPastaPasta referenced this in commit 4bb42c5c07 on Jul 1, 2021
PastaPastaPasta referenced this in commit db0cc20f55 on Jul 1, 2021
UdjinM6 referenced this in commit 4862d9c864 on Jul 5, 2021
PastaPastaPasta referenced this in commit 752797b6bf on Jul 8, 2021
Fabcien referenced this in commit b71a95f6fd on Aug 24, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7157 Fix typos and misc cleanup.#14164 Update univalue subtree