[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories lib #14892

pull Empact wants to merge 1 commits into bitcoin:master from Empact:factories changing 8 files +107 −103

Empact commented at 10:29 AM on December 7, 2018: member

This is a first step toward a library of common factory functions for test and bench purposes. In my experience this is a useful resource to test-writers, and helps make the tests more maintainable by reducing duplication across them.

Prompted by the "FIXME:" comment in src/bench/verify_script.cpp
Empact commented at 10:59 AM on December 7, 2018: member

Pending me figuring out MSVC build.
Empact renamed this:
~~test: Extract BuildCrediting/SpendingTransaction to shared factories folder~~
[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder
on Dec 7, 2018
Empact renamed this:
~~[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories folder~~
[WIP] test: Extract BuildCrediting/SpendingTransaction to shared factories lib
on Dec 7, 2018

test: Extract BuildCrediting/SpendingTransaction to shared factories folder

This is a first step toward a library of common factory functions for test and
bench purposes.

0ee42a10ec

Contributors