[backport] #14679 importmulti: Don’t add internal addresses to address book #14900

1. 
   fanquake commented at 2:48 pm on December 9, 2018: member
2. importmulti: Don't add internal addresses to address book

   Github-Pull: #14679
   Rebased-From: 7afddfa8cefd01249ad59cf2370e7cec90b34f6f

   ae1b6756c9
3. fanquake added the label Wallet on Dec 9, 2018
4. fanquake added the label Backport on Dec 9, 2018
5. fanquake added this to the milestone 0.17.2 on Dec 9, 2018
6. fanquake requested review from instagibbs on Dec 9, 2018
7. 
   meshcollider commented at 4:29 am on December 10, 2018: contributor

   utACK https://github.com/bitcoin/bitcoin/pull/14900/commits/ae1b6756c96f78985e88fa5b0c68ccad90f5e259

   Test no longer includes the ischange asserts because that field was only introduced in #14410

8. 
   jonasschnelli commented at 6:03 am on December 10, 2018: contributor

   utACK ae1b6756c96f78985e88fa5b0c68ccad90f5e259
9. 
   laanwj commented at 11:42 am on December 10, 2018: member

   utACK ae1b6756c96f78985e88fa5b0c68ccad90f5e259
10. 
    instagibbs commented at 2:06 pm on December 10, 2018: member

    utACK https://github.com/bitcoin/bitcoin/pull/14900/commits/ae1b6756c96f78985e88fa5b0c68ccad90f5e259
11. 
    promag commented at 8:44 pm on December 11, 2018: member

    Ref #14679.

    ACK ae1b6756, repeated the rebase and verified the changes.

    I wonder if #14410 should be backported? — if so this needs to be updated.

12. 
    sipa commented at 9:45 pm on December 11, 2018: member

    utACK ae1b6756c96f78985e88fa5b0c68ccad90f5e259
13. 
    instagibbs commented at 9:51 pm on December 11, 2018: member

    @promag depends on when the point release should be going out.
14. meshcollider merged this on Dec 24, 2018
15. meshcollider closed this on Dec 24, 2018

    ---

16. meshcollider referenced this in commit a057cc08fd on Dec 24, 2018
17. fanquake deleted the branch on Dec 24, 2018
18. DrahtBot locked this on Sep 8, 2021

Contributors
fanquake meshcollider jonasschnelli laanwj instagibbs promag sipa

Review Requested
instagibbs

Labels
Wallet Backport

Milestone
0.17.2