[backport] #14679 importmulti: Don't add internal addresses to address book #14900

pull fanquake wants to merge 1 commits into bitcoin:0.17 from fanquake:backport-14679 changing 2 files +8 −6

fanquake commented at 2:48 PM on December 9, 2018: member

No description provided.

importmulti: Don't add internal addresses to address book

Github-Pull: #14679
Rebased-From: 7afddfa8cefd01249ad59cf2370e7cec90b34f6f

ae1b6756c9

fanquake added the label Wallet on Dec 9, 2018
fanquake added the label Backport on Dec 9, 2018
fanquake added this to the milestone 0.17.2 on Dec 9, 2018
fanquake requested review from instagibbs on Dec 9, 2018
meshcollider commented at 4:29 AM on December 10, 2018: contributor

utACK https://github.com/bitcoin/bitcoin/pull/14900/commits/ae1b6756c96f78985e88fa5b0c68ccad90f5e259

Test no longer includes the ischange asserts because that field was only introduced in #14410
jonasschnelli commented at 6:03 AM on December 10, 2018: contributor

utACK ae1b6756c96f78985e88fa5b0c68ccad90f5e259
laanwj commented at 11:42 AM on December 10, 2018: member

utACK ae1b6756c96f78985e88fa5b0c68ccad90f5e259
instagibbs commented at 2:06 PM on December 10, 2018: member

utACK https://github.com/bitcoin/bitcoin/pull/14900/commits/ae1b6756c96f78985e88fa5b0c68ccad90f5e259
promag commented at 8:44 PM on December 11, 2018: member

Ref #14679.

ACK ae1b6756, repeated the rebase and verified the changes.

I wonder if #14410 should be backported? — if so this needs to be updated.
sipa commented at 9:45 PM on December 11, 2018: member

utACK ae1b6756c96f78985e88fa5b0c68ccad90f5e259
instagibbs commented at 9:51 PM on December 11, 2018: member

@promag depends on when the point release should be going out.
meshcollider merged this on Dec 24, 2018
meshcollider closed this on Dec 24, 2018
meshcollider referenced this in commit a057cc08fd on Dec 24, 2018
fanquake deleted the branch on Dec 24, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Review Requested
instagibbs

Labels

Wallet Backport

Milestone
0.17.2