It appears that the current witness would be preserved even if the transaction passed to deserialize has no witness.
test: Correctly deserialize without witness #14925
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1812-testWitnessDeser changing 1 files +2 −0-
MarcoFalke commented at 6:24 PM on December 11, 2018: member
-
test: Correctly deserialize without witness fae3617d79
- MarcoFalke added the label Tests on Dec 11, 2018
- MarcoFalke added this to the milestone 0.18.0 on Dec 11, 2018
- MarcoFalke removed this from the milestone 0.18.0 on Dec 11, 2018
-
laanwj commented at 12:38 PM on December 13, 2018: member
Concept ACK. Hmm, all tests pass before and after this. Would be nice to have a test that fails with this and passes with it.
- laanwj merged this on Dec 13, 2018
- laanwj closed this on Dec 13, 2018
-
- MarcoFalke deleted the branch on Dec 13, 2018
-
MarcoFalke commented at 6:06 PM on December 13, 2018: member
Indeed, you could revert the top commit of the other pull and it would fail the mempool_accept test
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels