test: consensus: Check that final transactions are valid #14926

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1812-testConsensusFinal changing 2 files +21 −1
  1. MarcoFalke commented at 6:37 PM on December 11, 2018: member

    There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.

  2. test: Correctly deserialize without witness fae3617d79
  3. MarcoFalke added the label Tests on Dec 11, 2018
  4. test: consensus: Check that final transactions are valid aaaa8eb1ed
  5. MarcoFalke force-pushed on Dec 11, 2018
  6. DrahtBot commented at 11:27 PM on December 11, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--2502f1a698b3751726fa55edcda76cd3-->

    Coverage

    Coverage Change (pull 14926) Reference (master)
    Lines -0.0086 % 87.2539 %
    Functions +0.0454 % 84.3991 %
    Branches +0.0035 % 51.3393 %

    <sup>Updated at: 2018-12-11T23:27:22.466952.</sup>

  7. laanwj commented at 1:22 PM on December 13, 2018: member

    utACK aaaa8eb1edba2a28916d5da6001d421c1b1b253b, thanks for adding consensus code test coverage!

  8. laanwj merged this on Dec 13, 2018
  9. laanwj closed this on Dec 13, 2018

  10. laanwj referenced this in commit 7202ae2e1b on Dec 13, 2018
  11. MarcoFalke deleted the branch on Dec 13, 2018
  12. christiancfifi referenced this in commit e63db06138 on Aug 24, 2021
  13. christiancfifi referenced this in commit 6590ec9b49 on Aug 24, 2021
  14. christiancfifi referenced this in commit 2f94d70034 on Aug 25, 2021
  15. christiancfifi referenced this in commit c436fd7d5b on Aug 26, 2021
  16. christiancfifi referenced this in commit eb71903958 on Aug 28, 2021
  17. christiancfifi referenced this in commit 1b8d4e607e on Aug 29, 2021
  18. christiancfifi referenced this in commit ecf066ebaa on Aug 29, 2021
  19. christiancfifi referenced this in commit 5898960c72 on Aug 29, 2021
  20. MarcoFalke locked this on Sep 8, 2021
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me