There is no check that checks that final transactions are valid, i.e. the consensus rules could be changed (accidentally) with none of the tests failing.
test: consensus: Check that final transactions are valid #14926
pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1812-testConsensusFinal changing 2 files +21 −1-
MarcoFalke commented at 6:37 PM on December 11, 2018: member
-
test: Correctly deserialize without witness fae3617d79
- MarcoFalke added the label Tests on Dec 11, 2018
-
test: consensus: Check that final transactions are valid aaaa8eb1ed
- MarcoFalke force-pushed on Dec 11, 2018
-
DrahtBot commented at 11:27 PM on December 11, 2018: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--2502f1a698b3751726fa55edcda76cd3-->
Coverage
Coverage Change (pull 14926) Reference (master) Lines -0.0086 % 87.2539 % Functions +0.0454 % 84.3991 % Branches +0.0035 % 51.3393 % <sup>Updated at: 2018-12-11T23:27:22.466952.</sup>
-
MarcoFalke commented at 11:33 PM on December 11, 2018: member
-
laanwj commented at 1:22 PM on December 13, 2018: member
utACK aaaa8eb1edba2a28916d5da6001d421c1b1b253b, thanks for adding consensus code test coverage!
- laanwj merged this on Dec 13, 2018
- laanwj closed this on Dec 13, 2018
- laanwj referenced this in commit 7202ae2e1b on Dec 13, 2018
- MarcoFalke deleted the branch on Dec 13, 2018
- christiancfifi referenced this in commit e63db06138 on Aug 24, 2021
- christiancfifi referenced this in commit 6590ec9b49 on Aug 24, 2021
- christiancfifi referenced this in commit 2f94d70034 on Aug 25, 2021
- christiancfifi referenced this in commit c436fd7d5b on Aug 26, 2021
- christiancfifi referenced this in commit eb71903958 on Aug 28, 2021
- christiancfifi referenced this in commit 1b8d4e607e on Aug 29, 2021
- christiancfifi referenced this in commit ecf066ebaa on Aug 29, 2021
- christiancfifi referenced this in commit 5898960c72 on Aug 29, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels