doc: Improve Windows native build instructions #14973

pull murrayn wants to merge 1 commits into bitcoin:master from murrayn:win_build_doc changing 1 files +4 −11

murrayn commented at 12:11 PM on December 16, 2018: contributor

The current instructions assume usage of PowerShell; running in a Command Prompt results in a syntax error. Proposed change works with both Command Prompt and PowerShell.

Also a few other minor formatting changes.
fanquake added the label Docs on Dec 16, 2018
fanquake requested review from ken2812221 on Dec 17, 2018
fanquake commented at 2:31 PM on December 17, 2018: member

@sipsorcery Can you review?

in build_msvc/README.md:40 in 8feac5252e outdated

  45 | -    openssl:x64-windows-static `
  46 | -    zeromq:x64-windows-static `
  47 | -    berkeleydb:x64-windows-static `
  48 | -    secp256k1:x64-windows-static `
  49 | -    leveldb:x64-windows-static
  50 | +    PS >.\vcpkg install boost:x64-windows-static libevent:x64-windows-static openssl:x64-windows-static zeromq:x64-windows-static berkeleydb:x64-windows-static secp256k1:x64-windows-static leveldb:x64-windows-static

ken2812221 commented at 2:34 PM on December 17, 2018:

Could use .\vcpkg install --triplet x64-windows-static boost-filesystem boost-signals2 boost-test libevent openssl zeromq berkeleydb secp256k1 leveldb instead. Don't have to install all boost dependencies.

sipsorcery commented at 3:45 PM on December 17, 2018:

+1 for switching to @ken2812221's vcpkg command (see note below).

ken2812221 commented at 2:41 PM on December 17, 2018: contributor

Concept ACK
fanquake renamed this:
~~Improve Windows native build instructions~~
doc: Improve Windows native build instructions
on Dec 17, 2018
sipsorcery commented at 3:44 PM on December 17, 2018: member

tACK. @ken2812221 I ran an appveyor build with each of the twovcpkg commands below and both dragged in the exact same 80 packages, 70 of which were boost.

Your version is an improvement as it's shorter and I guess if the Boost dependency chain ever changes it could end up pulling in less packages.

vcpkg install --triplet x64-windows-static boost-filesystem boost-signals2 boost-test libevent openssl zeromq berkeleydb secp256k1 leveldb

vcpkg install boost:x64-windows-static libevent:x64-windows-static openssl:x64-windows-static zeromq:x64-windows-static berkeleydb:x64-windows-static secp256k1:x64-windows-static leveldb:x64-windows-static
Modify build instructions to work with Command Prompt as well as
PowerShell; other minor changes
523785042b
murrayn force-pushed on Dec 18, 2018
murrayn commented at 2:19 AM on December 19, 2018: contributor

I've incorporated @ken2812221 's suggestion.
fanquake commented at 2:37 AM on December 19, 2018: member

utACK 5237850
sipsorcery commented at 7:26 AM on December 19, 2018: member

tACK 523785042b5fccda981d85a7ea85a8ce30fe1709.
laanwj merged this on Dec 28, 2018
laanwj closed this on Dec 28, 2018
laanwj referenced this in commit 5d118faabf on Dec 28, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels