[Qt] Restore < Qt5.6 compatibility for addAction #14979

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2018/12/fix_addaction changing 1 files +12 −7

jonasschnelli commented at 6:30 AM on December 17, 2018: contributor

#14573 broke < Qt5.6 compatibility due to calling the lambda version of addAction that was added in Qt5.6.

This PR re-enables < Qt5.6 compatibility.
[Qt] Restore < Qt5.6 compatibility for addAction 3e21b690d1
jonasschnelli added the label GUI on Dec 17, 2018

fanquake commented at 6:57 AM on December 17, 2018: member

For reference a failed build is here, with log:

bitcoingui.o `test -f 'qt/bitcoingui.cpp' || echo './'`qt/bitcoingui.cpp
qt/bitcoingui.cpp:403:45: error: no matching member function for call to 'addAction'
    QAction* minimize_action = window_menu->addAction(tr("Minimize"), [] {
                               ~~~~~~~~~~~~~^~~~~~~~~
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:78:14: note: candidate function not viable: no known conversion from '(lambda at qt/bitcoingui.cpp:403:71)' to 'const QObject *' for 2nd argument
    QAction *addAction(const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:77:14: note: candidate function not viable: requires 2 arguments, but 3 were provided
    QAction *addAction(const QIcon &icon, const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:538:10: note: candidate function not viable: requires single argument 'action', but 3 arguments were provided
    void addAction(QAction *action);
         ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:76:14: note: candidate function not viable: requires single argument 'text', but 3 arguments were provided
    QAction *addAction(const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:79:14: note: candidate function not viable: requires at least 4 arguments, but 3 were provided
    QAction *addAction(const QIcon &icon, const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
qt/bitcoingui.cpp:425:44: error: no matching member function for call to 'addAction'
    QAction* restore_action = window_menu->addAction(tr("Restore"), [] {
                              ~~~~~~~~~~~~~^~~~~~~~~
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:77:14: note: candidate function not viable: no known conversion from 'QString' to 'const QIcon' for 1st argument
    QAction *addAction(const QIcon &icon, const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:538:10: note: candidate function not viable: requires single argument 'action', but 2 arguments were provided
    void addAction(QAction *action);
         ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:76:14: note: candidate function not viable: requires single argument 'text', but 2 arguments were provided
    QAction *addAction(const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:78:14: note: candidate function not viable: requires at least 3 arguments, but 2 were provided
    QAction *addAction(const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:79:14: note: candidate function not viable: requires at least 4 arguments, but 2 were provided
    QAction *addAction(const QIcon &icon, const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
qt/bitcoingui.cpp:436:22: error: no matching member function for call to 'addAction'
        window_menu->addAction(tr("Main Window"), [this] {
        ~~~~~~~~~~~~~^~~~~~~~~
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:77:14: note: candidate function not viable: no known conversion from 'QString' to 'const QIcon' for 1st argument
    QAction *addAction(const QIcon &icon, const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:538:10: note: candidate function not viable: requires single argument 'action', but 2 arguments were provided
    void addAction(QAction *action);
         ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:76:14: note: candidate function not viable: requires single argument 'text', but 2 arguments were provided
    QAction *addAction(const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:78:14: note: candidate function not viable: requires at least 3 arguments, but 2 were provided
    QAction *addAction(const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:79:14: note: candidate function not viable: requires at least 4 arguments, but 2 were provided
    QAction *addAction(const QIcon &icon, const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
qt/bitcoingui.cpp:447:22: error: no matching member function for call to 'addAction'
        window_menu->addAction(rpcConsole->tabTitle(tab_type), [this, tab_type] {
        ~~~~~~~~~~~~~^~~~~~~~~
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:77:14: note: candidate function not viable: no known conversion from 'QString' to 'const QIcon' for 1st argument
    QAction *addAction(const QIcon &icon, const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:538:10: note: candidate function not viable: requires single argument 'action', but 2 arguments were provided
    void addAction(QAction *action);
         ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:76:14: note: candidate function not viable: requires single argument 'text', but 2 arguments were provided
    QAction *addAction(const QString &text);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:78:14: note: candidate function not viable: requires at least 3 arguments, but 2 were provided
    QAction *addAction(const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qmenu.h:79:14: note: candidate function not viable: requires at least 4 arguments, but 2 were provided
    QAction *addAction(const QIcon &icon, const QString &text, const QObject *receiver, const char* member, const QKeySequence &shortcut = 0);
             ^
4 errors generated.
make[2]: *** [qt/qt_libbitcoinqt_a-bitcoingui.o] Error 1

promag commented at 9:29 AM on December 17, 2018: member

Thanks, utACK 3e21b690.
laanwj commented at 10:51 AM on December 17, 2018: member

whoops utACK
fanquake commented at 10:55 AM on December 17, 2018: member

utACK 3e21b69
laanwj merged this on Dec 17, 2018
laanwj closed this on Dec 17, 2018
laanwj referenced this in commit bfd7e54097 on Dec 17, 2018
luke-jr referenced this in commit 487c173ab5 on Dec 24, 2018
luke-jr referenced this in commit a867c37069 on Dec 26, 2018
MarcoFalke referenced this in commit 2c0867a181 on Feb 1, 2019
deadalnix referenced this in commit 631d110c68 on Oct 12, 2020
jasonbcox referenced this in commit b01ba2ed25 on Oct 13, 2020
ftrader referenced this in commit b515ce60ff on Apr 14, 2021
christiancfifi referenced this in commit ea528f8998 on Aug 24, 2021
christiancfifi referenced this in commit 59933c0265 on Aug 24, 2021
christiancfifi referenced this in commit c77cc5d5b2 on Aug 25, 2021
christiancfifi referenced this in commit ca2508fb30 on Aug 25, 2021
christiancfifi referenced this in commit e9956d267e on Aug 26, 2021
christiancfifi referenced this in commit f97a0e8fb1 on Aug 28, 2021
christiancfifi referenced this in commit 4e02ba7ff7 on Aug 29, 2021
christiancfifi referenced this in commit 67f109eaee on Aug 29, 2021
christiancfifi referenced this in commit 146871ad57 on Aug 29, 2021
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#14573 qt: Add Window menu #14983 One Travis instance should run minimum supported QT version #14998 Run CI against ubuntu 14.04 #15308 build: Restore compatibility with older boost #15320 [Do Not Merge] break < Qt5.6 compatibility for addAction to test Travis