rpc: Clarifying RPC getrawtransaction's time help text #14981

1. 
   benthecarman commented at 12:38 PM on December 17, 2018: contributor

   #12339

   The time and blocktime entries have the same value so they should have the same help text as well

2. fanquake added the label Docs on Dec 17, 2018
3. fanquake added the label RPC/REST/ZMQ on Dec 17, 2018
4. in src/rpc/rawtransaction.cpp:133 in 4504b58552 outdated

    129 | @@ -130,7 +130,7 @@ static UniValue getrawtransaction(const JSONRPCRequest& request)
    130 |              "  ],\n"
    131 |              "  \"blockhash\" : \"hash\",   (string) the block hash\n"
    132 |              "  \"confirmations\" : n,      (numeric) The confirmations\n"
    133 | -            "  \"time\" : ttt,             (numeric) The transaction time in seconds since epoch (Jan 1 1970 GMT)\n"
    134 | +            "  \"time\" : ttt,             (numeric) The block time in seconds since epoch (Jan 1 1970 GMT)\n"
    135 |              "  \"blocktime\" : ttt         (numeric) The block time in seconds since epoch (Jan 1 1970 GMT)\n"
   

   ---

   ---

   

   laanwj commented at 12:58 PM on December 17, 2018:

   concept ACK, the code is in TxToJSON:

                   entry.pushKV("time", pindex->GetBlockTime());
                   entry.pushKV("blocktime", pindex->GetBlockTime());
   

   though instead of repeating the text I'd prefer Same as \"blocktime\"\n

5. vinhmako99777 approved
6. benthecarman force-pushed on Dec 17, 2018
7. 
   promag commented at 2:35 PM on December 17, 2018: member

   Concept ACK.

   You have to rebase with master.

8. 
   MarcoFalke commented at 3:58 PM on December 17, 2018: member

   utACK 845d14cff70c5da741952c2395adbead263516a5

9. 
   promag commented at 4:13 PM on December 17, 2018: member

   utACK 845d14c.

10. MarcoFalke added this to the milestone 0.18.0 on Dec 17, 2018
11. 
    promag commented at 4:59 PM on December 17, 2018: member

    Invalid push? Reset to 845d14c?

12. 
    benthecarman commented at 4:59 PM on December 17, 2018: contributor

    Invalid push? Reset to 845d14c?

    Yeah my bad

13. benthecarman force-pushed on Dec 17, 2018
14. clarifying getrawtransaction[time] get help text 84104c781a
15. benthecarman force-pushed on Dec 17, 2018
16. 
    MarcoFalke commented at 6:05 PM on December 17, 2018: member

    No need to rebase. Could just force push the already reviewed commit?

17. 
    benthecarman commented at 6:39 PM on December 17, 2018: contributor

    No need to rebase. Could just force push the already reviewed commit?

    I thought the same thing but @promag asked for a rebase

18. 
    MarcoFalke commented at 7:50 PM on December 17, 2018: member

    We had issues with travis earlier today, but it is possible to just reset a travis run without a rebase or otherwise touching the commit.

19. 
    benthecarman commented at 8:07 PM on December 17, 2018: contributor

    I did not know that, but good to know

20. benthecarman renamed this:
    Clarifying RPC getrawtransaction's time help text
    rpc: Clarifying RPC getrawtransaction's time help text
    on Dec 18, 2018
21. 
    fanquake commented at 11:16 AM on December 28, 2018: member

    utACK 84104c7

22. MarcoFalke merged this on Dec 28, 2018
23. MarcoFalke closed this on Dec 28, 2018

    ---

24. MarcoFalke referenced this in commit ea0b1990d1 on Dec 28, 2018
25. benthecarman deleted the branch on Dec 29, 2018
26. jasonbcox referenced this in commit 807ed300fa on Oct 2, 2020
27. christiancfifi referenced this in commit db718907c4 on Aug 24, 2021
28. christiancfifi referenced this in commit 8583a99307 on Aug 24, 2021
29. christiancfifi referenced this in commit cf22be7a4c on Aug 25, 2021
30. christiancfifi referenced this in commit af89aa9af0 on Aug 25, 2021
31. christiancfifi referenced this in commit a0eceef952 on Aug 26, 2021
32. christiancfifi referenced this in commit 4488338dce on Aug 28, 2021
33. christiancfifi referenced this in commit 07601b8ec2 on Aug 29, 2021
34. christiancfifi referenced this in commit 0d06956b17 on Aug 29, 2021
35. christiancfifi referenced this in commit cf64b534ab on Aug 29, 2021
36. MarcoFalke locked this on Sep 8, 2021

Contributors

benthecarmanlaanwjvinhmako99777promagMarcoFalkefanquake

Milestone
0.18.0