update QRCodeDialog #1518

• remove unused #include <QDebug> and lblBTC label
• update Bitcoin input field to a BitcoinAmountField to allow Bitcoin unit selection
• use BitcoinUnits::format for the resulting amount parameter in the generated URI (always use BTC as per BIP21)
• move MAX_URI_LENGTH and EXPORT_IMAGE_SIZE to guiconstants.h
• add OptionsModel in AddressBookPage and use it in on_showQRCode_clicked() to pass it to QRCodeDialog
• add OptionsModel in QRCodeDialog to enable display unit updates
• add updateDisplayUnit() slot to be able to imediately update currently set bitcoin unit
• make all labels in the UI-file plain text
• resize dialog to match for an updated layout (fields are now stacked and new field)
• remove unused parameters from private slots
• only enable save button, when QR Code was generated
• show message when entered amound is invalid
• add read-only QPlainTextEdit field to output generated URI

Fixes: #1506

There's another thing that might eventually be useful in the QR code dialog: showing the constructed bitcoin: URL (above the image?), so it can be copy/pasted into mails and such.

That is rather easy to achieve, are you ok with the code and changes thus far? I can integrate your suggestion here or create another pull on top ... just as you like.

It was just a random idea, doesn't have to be in this pull.

Am I right that QRCodeDialog::setModel is never called? Did you test it? Looks like addressBookPage needs a setOptionsModel to pass on to QRCodeDialog.

I'm working on your idea right now :). setModel() is unused, because I didn't know, how to get easy access to the options model :-/. Any hint / idea?

Updated:

• add read-only QPlainTextEdit field to output generated URI

I chose an TextEdit to be able to use word-wrap and see the whole URI, drawback is, that I was unable to implement a working EventFilter to select all text without messing up other behaviour of the TextEdit field. A copy URI button could be added before the "Save As..." one though.

Nice!

I'd add a setOptionsModel method (called from BitcoinGUI::setClientModel) to AddressBookPage, which stores the options model. Then when creating the QRCodeDialog you can pass it.

@laanwj Thanks mate :). I'll update to integrate your suggestion and do this as seperate commit, so you can see easily what was changed. After your final ACK I can merge that commit, so we only have one if you want.

Updated:

• add OptionsModel in AddressBookPage and use it in on_showQRCode_clicked() to pass it to QRCodeDialog

I verified this to work.

@laanwj Same here, is it possible to get this into 0.7, before the RC phase? Any further things I need to fix, suggestions or such stuff?

ACK

Rebased and merged both commits into one, no code changes.