[PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] #15064

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:bip70_merchant_to_to changing 8 files +87 −0

luke-jr commented at 10:59 AM on December 30, 2018: member

The idea being to save this information in a usable format before we remove BIP70 entirely...

Thoughts?
GUI: Migrate BIP70 merchant info to mapValue["to"] 78097bb89d
fanquake added the label GUI on Dec 30, 2018
fanquake added the label Brainstorming on Dec 30, 2018

in src/interfaces/wallet.cpp:357 in 78097bb89d

 353 | @@ -354,6 +354,13 @@ class WalletImpl : public Wallet
 354 |          }
 355 |          return {};
 356 |      }
 357 | +    bool writeWalletTxValues(const uint256& txid, std::map<std::string, std::string> new_map)

practicalswift commented at 11:50 PM on December 30, 2018:

Should be marked override?

DrahtBot commented at 4:44 PM on January 3, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #13756 (wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof)
- #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
jonasschnelli commented at 8:16 PM on January 3, 2019: contributor

Unsure about this... what is the long term use case for the stored data? Would it eventually be more straight forward to give steps how to keep the BIP70 data in a release notes (once completely removed)? Or would altering "dumpwallet" with an option to dump the BIP70 stuff make sense?
luke-jr commented at 11:04 PM on January 3, 2019: member

The BIP70 stuff is currently stored in a protobuf-encoded format IIRC, so accessing it post-removal or even from RPC would be invasive.
laanwj commented at 2:36 PM on January 8, 2019: member

I think this makes some sense in context of deprecating BIP70. The data should remain in the wallet (for legal/historical purposes) but will effectively become inaccessible. Migrating it to another field makes sure that something of the historical metadata is visible even after BIP70 parsing is removed.
DrahtBot commented at 11:59 PM on June 18, 2019: member

Needs rebase
DrahtBot added the label Needs rebase on Jun 18, 2019
laanwj commented at 7:30 PM on September 12, 2019: member

closing in favor of #16852 (if it works)
laanwj closed this on Sep 12, 2019
laanwj removed the label Needs rebase on Oct 24, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

[PoC] GUI: Migrate BIP70 merchant info to mapValue["to"] #15064

Conflicts