0.17: GUI Backports #14123 #14133 #14383 #14597 #15065

1. 
   promag commented at 11:29 AM on December 30, 2018: member

   Backport #14123 #14133 #14383 and #14597 to 0.17 branch to fix #13606 (comment).

2. gui: Favor macOS show / hide action in dock menu

   Github-Pull: #14133
   Rebased-From: ee3a494f37d6a459a5d935446ba08d69ea310b9b

   298dc15686
3. Clean systray icon menu for -disablewallet mode

   Ref #3392
   
   Github-Pull: #14383
   Rebased-From: 36323e2ac6cca134de47b06c3f6403de91ee9eda

   d2ed162ce0
4. Remove obj_c for macOS Dock icon setting

   Qt `setWindowIcon()` does this work.
   
   Github-Pull: #14597
   Rebased-From: 53bb6be3f8a50ee9e5c4d7e9155236152e7c4b7c

   4d4bc37df9
5. Use Qt signal for macOS Dock icon click event

   This moves the Dock icon click reaction code to the common place and
   allows some cleanup in obj_c code.
   
   According to the Apple's docs `class_replaceMethod` behaves as
   `class_addMethod`, if the method identified by name does not yet exist;
   or as `method_setImplementation`, if it does exist.
   
   Github-Pull: #14597
   Rebased-From: 2464925e7be832d4926b6204169bbbc1646c6368

   90347141bd
6. Remove obj_c for macOS Dock icon menu

   Qt `setAsDockMenu()` does this work.
   
   Github-Pull: #14597
   Rebased-From: 6b1d2972bf9a40f97ba3a5c95831fd179b1054cf

   0c2fb87dc1
7. qt: Add GUIUtil::bringToFront

   Github-Pull: #14123
   Rebased-From: 5796671e1dd8a2d0b1e750c2dce19a10af624095

   ac73c7d433
8. qt: Use GUIUtil::bringToFront where possible

   Github-Pull: #14123
   Rebased-From: 6fc21aca6d5e16c3ece104fec8e5b3df116893b4

   c470bbd19d
9. qt: All tray menu actions call showNormalIfMinimized

   Github-Pull: #14123
   Rebased-From: 0a656f85a9c694f25b06c6464d6e986816eecd58

   27beb83222
10. fanquake added the label Backport on Dec 30, 2018
11. fanquake added this to the milestone 0.17.2 on Dec 30, 2018
12. MarcoFalke renamed this:
    0.17: Backport #14123 #14133 #14383 #14597
    0.17: GUI Backports #14123 #14133 #14383 #14597
    on Dec 30, 2018
13. MarcoFalke added the label GUI on Dec 30, 2018
14. 
    fanquake commented at 1:25 PM on January 2, 2019: member

    Tested on macOS 10.14.2 (qt 5.12.0) on top of 16521ce08676db36d1e1db65749e54180d5201b4. Note that 27beb83 differs from it's rebased-from commit https://github.com/bitcoin/bitcoin/commit/0a656f85a9c694f25b06c6464d6e986816eecd58.

    Checked that the dock icon appears correctly. Checked that it's using the native show/hide controls. Checked that #13829 doesn't occur. Tested that passing -disablewallet modifies the dock menu as expected i.e:

15. 
    promag commented at 2:31 PM on January 2, 2019: member

    Thanks @fanquake, I think that's it.

16. 
    laanwj commented at 3:08 PM on January 2, 2019: member

    utACK 27beb8322297d70dccc4db0605b22470e50e9010

17. 
    hebasto commented at 10:53 PM on January 2, 2019: member

    tACK 27beb8322297d70dccc4db0605b22470e50e9010 (Linux Mint 19.2, macOS 10.13.6).

18. laanwj merged this on Jan 3, 2019
19. laanwj closed this on Jan 3, 2019

    ---

20. laanwj referenced this in commit 5ff7b372cd on Jan 3, 2019
21. DrahtBot locked this on Dec 16, 2021

Contributors

promagfanquakelaanwjhebasto

Milestone
0.17.2