rpc: List all message types in getpeerinfo recv/send stats #15077

1. 
   MarcoFalke commented at 11:29 pm on January 1, 2019: member

   Makes it easier to parse the json, since integers of 0 are no longer special cased. See for example #15069 where the special case was forgotten and lead to issues.
2. rpc: List all message types in getpeerinfo fa7d5a0c16
3. MarcoFalke added the label Tests on Jan 1, 2019
4. MarcoFalke added the label RPC/REST/ZMQ on Jan 1, 2019
5. MarcoFalke removed the label Tests on Jan 1, 2019
6. 
   Empact commented at 0:30 am on January 2, 2019: member

   utACK fa7d5a0
7. 
   laanwj commented at 9:28 am on January 2, 2019: member

   I’m not sure about this; from version to version, other messages will be added to these statistics. Client code (that needs to support multiple versions of bitcoin core) cannot assume their message will be in there unconditionally. That would make this 100% a change for the tests.

   This also marginally increases memory use per peer (but that’s likely not significant).

8. 
   MarcoFalke commented at 9:50 am on January 2, 2019: member

   Fine, but the documentation should mention that, otherwise it isn’t really clear.
9. MarcoFalke closed this on Jan 2, 2019

   ---

10. MarcoFalke deleted the branch on Jan 2, 2019
11. 
    jnewbery commented at 8:52 pm on January 7, 2019: member

    Concept ACK.

    Client code (that needs to support multiple versions of bitcoin core) cannot assume their message will be in there unconditionally.

    This argument doesn’t make sense to me. The client code should be aware of the server version that it’s connecting to. If we followed your argument to its conclusion, then we’d never make any changes to the RPC interface because a future client might try to use a new feature from an old server.

    I think this is an improvement. Would be happy to review if this was re-opened.

12. MarcoFalke locked this on Dec 16, 2021

Contributors
MarcoFalke Empact laanwj jnewbery

Labels
RPC/REST/ZMQ