Tests: Add unit testing for the CompressScript function #15104

pull mmachicao wants to merge 1 commits into bitcoin:master from mmachicao:compress_contract_test3 changing 1 files +85 −4

mmachicao commented at 4:07 PM on January 4, 2019: contributor
Added unit tests for CompressScript function located in: compressor.cpp

Tested following cases for the CScript:
- CKeyID
- CScriptID
- Uncompressed CPubKey (of size : 65)
- Compressed CPubKey (of size: 32)
fanquake added the label Tests on Jan 4, 2019
practicalswift commented at 4:22 PM on January 5, 2019: contributor

@mmachicao Nice first-time contribution! Can you measure the coverage before and after your patch?

DrahtBot commented at 7:12 PM on January 5, 2019: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15788 (test: Unify testing setups for fuzz, bench, and unit tests by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Coverage

Coverage	Change (pull 15104, eb0e9343315bf23eab513f9154e5ffd3ca11927a)	Reference (master, 9c719987718d9fcc3a689e50f5212acc7ead7606)
Lines	-0.0258 %	87.3841 %
Functions	-0.0151 %	84.4347 %
Branches	-0.0202 %	51.4189 %

<sup>Updated at: 2019-01-05T19:12:19.596954.</sup>

laanwj commented at 2:05 PM on January 9, 2019: member

Thanks for adding tests!

DrahtBot's coverage statistics show a decrease in coverage? I don't see how this is possible @MarcoFalke
Tests: Add unit testing for the CompressScript function.
Also: Third pary libraries are separated by a new line
36ada0983d
in src/test/compress_tests.cpp:5 in 6897f73430 outdated
```
   1 | @@ -2,13 +2,12 @@
   2 |  // Distributed under the MIT software license, see the accompanying
   3 |  // file COPYING or http://www.opensource.org/licenses/mit-license.php.
   4 |  
   5 | +#include <boost/test/unit_test.hpp>
```
MarcoFalke commented at 4:54 PM on January 14, 2019:

third-party libraries are separated by a new line (like it was before), so please don't change that.

laanwj commented at 5:06 PM on January 16, 2019:

Yes, please keep the order of includes the same and only add new ones where necessary.
laanwj commented at 2:06 PM on January 24, 2019: member

Feel free to take over this branch where I've cleaned up the changes to header ordering: https://github.com/laanwj/bitcoin/tree/2019_01_24_upd15104
DrahtBot added the label Needs rebase on Apr 16, 2019
DrahtBot commented at 5:15 PM on April 16, 2019: member

Needs rebase
fanquake added the label Up for grabs on Jul 29, 2019
fanquake closed this on Jul 29, 2019
MarcoFalke removed the label Up for grabs on Oct 22, 2019
laanwj removed the label Needs rebase on Oct 24, 2019
laanwj referenced this in commit 37855ec9df on Oct 25, 2019
PastaPastaPasta referenced this in commit c7abbd5096 on Nov 1, 2021
PastaPastaPasta referenced this in commit 38a0fbee54 on Nov 3, 2021
pravblockc referenced this in commit 13228b77da on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#17220 tests: Add unit testing for the CompressScript function