qt: "Peers" tab overhaul #15136

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20190109-peerstab-overhaul changing 2 files +587 −565

hebasto commented at 8:45 PM on January 9, 2019: member

This is an alternative to #14798.

The "Peers" tab of the "Debug" window improved to address comments #6209 (comment) (by @jonasschnelli) and #14798 (comment) (by @promag).

This allows to keep the peer selection while navigating to other places and effectively reverts e0597268116cf90d961abeba9d14aaad0ab682d2.

Screenshots with this PR:

Improve Peers tab layout

Using the QSplitter and QScrollArea classes.

b0037c5190

Do not deselect peer when switching away from tab

Effectevely reverts e0597268116cf90d961abeba9d14aaad0ab682d2 commit.

3537c8345c

DrahtBot commented at 10:45 PM on January 9, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #14810 (qt: Enable tabbing through labels by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake added the label GUI on Jan 9, 2019
jonasschnelli commented at 6:59 AM on January 10, 2019: contributor

Did a quick test and looks good (https://bitcoin.jonasschnelli.ch/build/946).

utACK 3537c8345c788a527bb4e1d00683ca7f8ee5fb1a
promag commented at 4:01 PM on January 10, 2019: member

tACK 3537c83 on macOS 10.14.2, keeping the selection looks better to me.

Will review changes to debugwindow.ui.
in src/qt/forms/debugwindow.ui:908 in 3537c8345c
```
1465 | -             </size>
1466 | -            </property>
1467 | -           </spacer>
1468 | -          </item>
1469 | -         </layout>
1470 | +         <widget class="QWidget" name="widget_1" native="true">
```
promag commented at 10:53 PM on January 14, 2019:

This could be the table?

hebasto commented at 11:04 PM on January 14, 2019:

QSplitter Class docs:

Note: Adding a QLayout to a QSplitter is not supported (either through setLayout() or making the QSplitter a parent of the QLayout); use addWidget() instead.

So, it cannot be a table or other kind of QLayout.
laanwj commented at 11:38 AM on January 16, 2019: member

utACK 3537c8345c788a527bb4e1d00683ca7f8ee5fb1a
laanwj merged this on Jan 16, 2019
laanwj closed this on Jan 16, 2019
laanwj referenced this in commit acec9e45c6 on Jan 16, 2019
hebasto deleted the branch on Jan 16, 2019
HashUnlimited commented at 11:23 AM on January 18, 2019: contributor

On macOS this broke the visibility of the Services (scrolled all way to the right end)

<img width="929" alt="screenshot 2019-01-18 at 12 20 32" src="https://user-images.githubusercontent.com/26601261/51384100-8e7af300-1b1b-11e9-8617-14967d6c9ec7.png">
hebasto commented at 12:30 PM on January 18, 2019: member

@HashUnlimited you can adjust a view by moving QSplitter bar (marked by a dot on your screenshot) and window borders:
HashUnlimited commented at 12:58 PM on January 18, 2019: contributor

ah OK... thanks. pretty confusing though that scrolling doesn't reveal all contents.
deadalnix referenced this in commit 952b59ff50 on Nov 28, 2020
Munkybooty referenced this in commit 70096c6cbc on Aug 21, 2021
christiancfifi referenced this in commit 631eaa17cc on Oct 3, 2021
christiancfifi referenced this in commit 6251b12682 on Oct 3, 2021
christiancfifi referenced this in commit 663a4f2b61 on Oct 4, 2021
christiancfifi referenced this in commit 2ee39d1b80 on Oct 4, 2021
christiancfifi referenced this in commit 487ae1a0a3 on Oct 5, 2021
christiancfifi referenced this in commit cba496356b on Oct 6, 2021
christiancfifi referenced this in commit 33a38b84de on Oct 11, 2021
pravblockc referenced this in commit fe18a9b066 on Nov 18, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#6209 [Qt] extend rpc console peers tab #14798 qt: Fix deselecting peer when switching from peers to console tab

qt: "Peers" tab overhaul #15136

Conflicts