The e0597268116cf90d961abeba9d14aaad0ab682d2 commit from #6209 was intended to deselect a peer when switching away from the Peers tab in the RPC console. But switching away from the Peers tab to the Console tab and back does not deselect a peer.
This PR makes tab switching consistent: a peer is always deselected when switching away from the Peers tab.
Deselect peer when switching away from Peers tab in RPC console. Now it
works for switching to Console tab and back as well.
utACK 22c867e5599045688907a96e7b6b33a35521837a
tACK 22c867e
master (327129f7a6440e3bbd0a0ea415ea5f8907cf3233):
This PR (22c867e):
The reason to deselect comes from @jonasschnelli comment #6209 (comment).
I think we could keep the selection while navigating to other places, after all, the user did select the peer for some reason. We could add a vertical scrollbar to the right pane or improve the layout if we want to allow a certain height.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
Just want to add that the we also don't reset the console nor the transactions list.
I think it's perfectly fine to keep the selection/state, even if the window is closed.